Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web-animations-1] Add dictionary default values #4235

Merged
merged 1 commit into from
Aug 22, 2019

Conversation

saschanaz
Copy link
Member

Required after whatwg/webidl#750. (Found from web-platform-tests/wpt#18382)

@saschanaz
Copy link
Member Author

Marked as non substantive for IPR from ash-nazg.

@birtles birtles merged commit 7c80650 into w3c:master Aug 22, 2019
@birtles
Copy link
Contributor

birtles commented Aug 22, 2019

Oh, actually this needs a little more work. e.g. the KeyframeEffect constructor has three lines:

  • If options is a KeyframeEffectOptions object ...
  • If options is a double ...
  • Otherwise (options is undefined) ...

But the last option is no longer necessary.

I think that might be all.

@birtles
Copy link
Contributor

birtles commented Aug 22, 2019

(Unrelated, but something else I noticed while looking into this was that step 4 of the description of animate fails to account for when options is a double.)

birtles added a commit to birtles/csswg-drafts that referenced this pull request Aug 23, 2019
As of w3c#4235 these arguments will always be set.

The change to animate() simply corrects an existing oversight.
@birtles
Copy link
Contributor

birtles commented Aug 23, 2019

I addressed the above issues in 3fafc22.

@saschanaz saschanaz deleted the patch-7 branch August 23, 2019 02:14
birtles added a commit that referenced this pull request Aug 29, 2019
As of #4235 these arguments will always be set.

The change to animate() simply corrects an existing oversight.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants