[resize-observer-1] Invoke callback with observer as 2nd argument and this value
#5383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Neither me nor greg are working on ResizeObserver right now, you should pick a current reviewer. |
ashkulz
pushed a commit
to qtwebkit/webkit-mirror
that referenced
this pull request
Aug 8, 2020
…is` value https://bugs.webkit.org/show_bug.cgi?id=215162 Reviewed by Geoffrey Garen. LayoutTests/imported/w3c: * web-platform-tests/intersection-observer/observer-callback-arguments-expected.txt: * web-platform-tests/performance-timeline/po-observe.any-expected.txt: * web-platform-tests/performance-timeline/po-observe.any.worker-expected.txt: * web-platform-tests/resize-observer/eventloop-expected.txt: * web-platform-tests/resize-observer/observe-expected.txt: Source/WebCore: This change utilizes CallbackThisObject] IDL attribute to invoke a callback of IntersectionObserver [1], ResizeObserver [2], and PerformanceObserver [3] with correct `this` value of its observer, aligning WebKit with Blink and Gecko. Tests: imported/w3c/web-platform-tests/intersection-observer/observer-callback-arguments.html imported/w3c/web-platform-tests/resize-observer/observe.html imported/w3c/web-platform-tests/performance-timeline/po-observe.any.js [1] https://w3c.github.io/IntersectionObserver/#notify-intersection-observers-algo (step 3.4) [2] w3c/csswg-drafts#5383 [3] https://w3c.github.io/performance-timeline/#queue-the-performanceobserver-task (step 3.3.5) * html/LazyLoadImageObserver.cpp: * page/IntersectionObserver.cpp: (WebCore::IntersectionObserver::notify): * page/IntersectionObserverCallback.h: * page/IntersectionObserverCallback.idl: * page/PerformanceObserver.cpp: (WebCore::PerformanceObserver::deliver): * page/PerformanceObserverCallback.h: * page/PerformanceObserverCallback.idl: * page/ResizeObserver.cpp: (WebCore::ResizeObserver::deliverObservations): * page/ResizeObserverCallback.h: * page/ResizeObserverCallback.idl: LayoutTests: * performance-api/performance-observer-basic-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@265397 268f45cc-cd09-0410-ab3c-d52691b4dbfc
|
shvaikalesh marked as non substantive for IPR from ash-nazg. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aligns
ResizeObserverspec (step 2.4) with implementations (WPT: test, results) and other observers:MutationObserver(step 5.4);IntersectionObserver(step 3.4);PerformanceObserver(step 3.3.5).Passing
observertocallbackenables users to reuse a singlecallbackfunction, which invokesunobservewith entry'starget, for multipleResizeObserverinstances.