Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-pseudo] text decorations on highlight pseudos (closes #6022) #6666

Merged
merged 6 commits into from
Jan 31, 2022

Conversation

delan
Copy link
Contributor

@delan delan commented Sep 22, 2021

This patch makes some further edits for #6022, clarifying that our rules for painting text decorations apply to both line decorations and emphasis marks, and that in effect, decorations will never be obscured by highlight backgrounds.

@delan delan changed the title [css-pseudo-4] clarify highlight decoration semantics (#6022) [css-pseudo-4] text decorations on highlight pseudos (#6022) Sep 22, 2021
@delan delan added the css-pseudo-4 Current Work label Nov 2, 2021
@delan delan changed the title [css-pseudo-4] text decorations on highlight pseudos (#6022) [css-pseudo] text decorations on highlight pseudos (#6022) Nov 2, 2021
@delan delan changed the title [css-pseudo] text decorations on highlight pseudos (#6022) [css-pseudo] text decorations on highlight pseudos (closes #6022) Nov 2, 2021
@delan delan marked this pull request as ready for review January 5, 2022 10:39
@delan delan requested a review from fantasai January 5, 2022 10:39
Copy link
Collaborator

@fantasai fantasai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one thing:

  • Don't add the word “Other”, it's “{Text} and {Text Decorations}” not “{Text which is a type of Text Decoration} and {Other Types of Text Decorations}”!
  • Squash+Rebase when you merge. (See drop-down next to GH's Merge button.)

@delan
Copy link
Contributor Author

delan commented Jan 25, 2022

Thanks @fantasai, done in 99cfe20. Yeah, that heading would be better clarified by something like “Text, Line Decorations, and Emphasis Marks”, but the body makes the same clarification anyway so it’s not really necessary.

@delan
Copy link
Contributor Author

delan commented Jan 25, 2022

@fantasai looks like I don’t have write access, could you please merge?

@frivoal
Copy link
Collaborator

frivoal commented Jan 31, 2022

I'm not @fantasai, but I do have merge access :) Merging.

@frivoal frivoal merged commit 1b149ad into w3c:main Jan 31, 2022
@delan delan deleted the highlight-text-decorations branch January 31, 2022 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css-pseudo-4 Current Work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants