-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-pseudo] text decorations on highlight pseudos (closes #6022) #6666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delan
changed the title
[css-pseudo-4] clarify highlight decoration semantics (#6022)
[css-pseudo-4] text decorations on highlight pseudos (#6022)
Sep 22, 2021
delan
changed the title
[css-pseudo-4] text decorations on highlight pseudos (#6022)
[css-pseudo] text decorations on highlight pseudos (#6022)
Nov 2, 2021
delan
changed the title
[css-pseudo] text decorations on highlight pseudos (#6022)
[css-pseudo] text decorations on highlight pseudos (closes #6022)
Nov 2, 2021
fantasai
approved these changes
Jan 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one thing:
- Don't add the word “Other”, it's “{Text} and {Text Decorations}” not “{Text which is a type of Text Decoration} and {Other Types of Text Decorations}”!
- Squash+Rebase when you merge. (See drop-down next to GH's Merge button.)
@fantasai looks like I don’t have write access, could you please merge? |
I'm not @fantasai, but I do have merge access :) Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes some further edits for #6022, clarifying that our rules for painting text decorations apply to both line decorations and emphasis marks, and that in effect, decorations will never be obscured by highlight backgrounds.