Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-contain-3] Make content-visibility animatable. #8737

Merged
merged 2 commits into from
Apr 20, 2023

Conversation

flackr
Copy link
Contributor

@flackr flackr commented Apr 19, 2023

Allow animating content-visibility as animation type discrete with special interpolation to avoid hidden values similar to visibility. Fixes #8627

Allow animating content-visibility as animation type discrete with
special interpolation to avoid hidden values similar to visibility.
Fixes w3c#8627
@flackr flackr requested a review from mirisuzanne April 19, 2023 15:00
@mirisuzanne
Copy link
Contributor

This generally makes sense to me. The linked resolution had a third aspect, and it's not clear to me if it needs to be captured here:

Follow the same pattern as display for ensuring that css animations cannot deactivate themselves. Currently following that pattern would mean treating auto and hidden as revert.

@flackr
Copy link
Contributor Author

flackr commented Apr 20, 2023

We're shifting away from that requirement for display as fewer special cases is simpler. See #6429 (comment)

Also I realized after making the recommendation for content-visibility that the same logic does not apply. content-visibility affects the visibility of its content, but the element itself remains visible (runs animations) even if set to hidden.

@mirisuzanne
Copy link
Contributor

Want to add a line in the changelog about this?

@flackr
Copy link
Contributor Author

flackr commented Apr 20, 2023

Want to add a line in the changelog about this?

Thanks for the reminder, done.

@flackr flackr merged commit 64fa7b9 into w3c:main Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[css-contain-4] Make content-visibility animatable
2 participants