Skip to content

Commit

Permalink
Rework audio description original and translation languages (#179)
Browse files Browse the repository at this point in the history
* Rework audio description original and translation languages

Closes #173 and #148.

Text Language Source updated to remove the link between it and Primary Language. Needed to introduce a new concept of a "nominal" original language for the programme, for the Original language of the Audio Description.

Added notes and examples about how to handle non-nominal original language in-image text in audio descriptions, and the potential need to translate it.

Tidied some of the existing notes.

* Change Primary Language to Default Language, add Original Language

Many editorial tweaks to ensure that we are not using the term "original language" in a way that could be confusing in comparison to "Original" or the newly defined "Original Language".

This change is intended to clarify the situation when content without an inherent textual language is transcribed, and what language it should be transcribed as.

* Remove notes about nominal language

* Add `#originalLang-root` extension and require it

* Change `daptm:langSrc` to use a BCP47 language code

Resolves #148 as per TTWG discussion.

* Make Text Language Source optional

* Fix `langSrc` in example

* Address review feedback

* change `daptm:originalLang` to a list `daptm:originalLangs` so that multiple language content can be properly represented
* fix up all the examples to match
* Make Original Language optional
* Make Text Language Source optional, and define a semantic for when it is omitted
* Fix up styling to remove the strange small text for notes and examples (other than examples that are code)
* Clarify how to represent transcript text with an inherent language vs without
* Remove the complex dependency on "Original Language" for text without an inherent language

* Address @cconcolato review feedback

* as -> since

* Address @cconcolato review feedback

* Fully specify `daptm:langSrc` including inheritance, allow empty string

* Editorial improvements

Move the XML constraints of `daptm:langSrc` into a bullet list for consistency with other sections defining such lists of constraints.
Simplify the inclusion of `daptm:langSrc` in Text objects, and make it a SHOULD with an explanation of the feasibility and risks of omitting it in favour of inheritance.
Widen the scope of the `#textLanguageSource` feature to all elements.

* Explicitly state the computed value is the specified value if present

* Address @cconcolato 's feedback

* Make SVG valid

* remove codeline attributes that got away last time

* Address some feedback

* Simplify note about As-Recorded scripts

* Extend `#xmlLang-root` to include Default Language requirements

i.e. that xml:lang cannot be empty.

* Delete Original Languages

Removes `daptm:originalLangs` and `#originalLangs-root` too.

* Simplify Script Event requirement for zero or more text objects

* Reorder bullets and para in Text Language Source

* Explain how to identify if Text is Original or Translation.

* Simplify language about "marking" translations

* Target implementers as well as authors in warning notes

* Address editorial feedback comments from @cconcolato

* Add note as suggested by @andreastai
  • Loading branch information
nigelmegitt authored Dec 21, 2023
1 parent f112658 commit 8d16753
Show file tree
Hide file tree
Showing 15 changed files with 581 additions and 410 deletions.
2 changes: 1 addition & 1 deletion examples/event-desc-descType.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<body>
<div begin="10s" end="13s">
<ttm:desc daptm:descType="pronunciationNote">[oːnʲ]</ttm:desc>
<p daptm:langSrc="original">Eóin looks around at the other assembly members.</p>
<p>Eóin looks around at the other assembly members.</p>
</div>
</body>
...
8 changes: 4 additions & 4 deletions examples/event-desc-multiple-descType.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,20 +3,20 @@
<div begin="10s" end="13s">
<ttm:desc daptm:descType="scene">Scene 1</ttm:desc>
<ttm:desc daptm:descType="plotSignificance">High</ttm:desc>
<p daptm:langSrc="original">
<p xml:lang="en">
<span>A woman climbs into a small sailing boat.</span>
</p>
<p xml:lang="fr" daptm:langSrc="translation">
<p xml:lang="fr" daptm:langSrc="en">
<span>Une femme monte à bord d'un petit bateau à voile.</span>
</p>
</div>
<div begin="18s" end="20s">
<ttm:desc daptm:descType="scene">Scene 1</ttm:desc>
<ttm:desc daptm:descType="plotSignificance">Low</ttm:desc>
<p daptm:langSrc="original">
<p xml:lang="en">
<span>The woman pulls the tiller and the boat turns.</span>
</p>
<p xml:lang="fr" daptm:langSrc="translation">
<p xml:lang="fr" daptm:langSrc="en">
<span>La femme tire sur la barre et le bateau tourne.</span>
</p>
</div>
Expand Down
8 changes: 4 additions & 4 deletions examples/event-desc.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,19 @@
<body>
<div begin="10s" end="13s">
<ttm:desc>Scene 1</ttm:desc>
<p daptm:langSrc="original">
<p xml:lang="en">
<span>A woman climbs into a small sailing boat.</span>
</p>
<p xml:lang="fr" daptm:langSrc="translation">
<p xml:lang="fr" daptm:langSrc="en">
<span>Une femme monte à bord d'un petit bateau à voile.</span>
</p>
</div>
<div begin="18s" end="20s">
<ttm:desc>Scene 1</ttm:desc>
<p daptm:langSrc="original">
<p xml:lang="en">
<span>The woman pulls the tiller and the boat turns.</span>
</p>
<p xml:lang="fr" daptm:langSrc="translation">
<p xml:lang="fr" daptm:langSrc="en">
<span>La femme tire sur la barre et le bateau tourne.</span>
</p>
</div>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
<tt xmlns="http://www.w3.org/ns/ttml"
xmlns:ttm="http://www.w3.org/ns/ttml#metadata"
xmlns:ttp="http://www.w3.org/ns/ttml#parameter"
xmlns:daptm="http://www.w3.org/ns/ttml/profile/dapt#metadata"
xml:lang="en"
ttp:contentProfiles="http://www.w3.org/ns/ttml/profile/dapt1.0/content"
xml:lang="en"
daptm:langSrc="fr"
daptm:workflowType="dubbing"
daptm:scriptType="preRecording">
<head>
Expand All @@ -14,10 +16,10 @@
</head>
<body>
<div begin="10s" end="13s" ttm:agent="character_1" daptm:onScreen="ON_OFF">
<p xml:lang="fr" daptm:langSrc="original">
<p xml:lang="fr" daptm:langSrc="fr">
<span>Et c'est grâce à ça qu'on va devenir riches.</span>
</p>
<p xml:lang="en" daptm:langSrc="translation">
<p xml:lang="en" daptm:langSrc="fr">
<span begin="0s">And thanks to that,</span><span begin="1.5s"> we're gonna get rich.</span>
</p>
</div>
Expand Down
8 changes: 5 additions & 3 deletions examples/intro-original-language-with-dub-language.xml
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
<tt xmlns="http://www.w3.org/ns/ttml"
xmlns:ttm="http://www.w3.org/ns/ttml#metadata"
xmlns:ttp="http://www.w3.org/ns/ttml#parameter"
xmlns:daptm="http://www.w3.org/ns/ttml/profile/dapt#metadata"
xml:lang="en"
ttp:contentProfiles="http://www.w3.org/ns/ttml/profile/dapt1.0/content"
xml:lang="en"
daptm:langSrc="fr"
daptm:workflowType="dubbing"
daptm:scriptType="translatedTranscript">
<head>
Expand All @@ -14,10 +16,10 @@
</head>
<body>
<div begin="10s" end="13s" ttm:agent="character_1">
<p xml:lang="fr" daptm:langSrc="original">
<p xml:lang="fr" daptm:langSrc="fr"> <!-- original -->
<span>Et c'est grâce à ça qu'on va devenir riches.</span>
</p>
<p xml:lang="en" daptm:langSrc="translation">
<p xml:lang="en" daptm:langSrc="fr"> <!-- translated -->
<span>And thanks to that, we're gonna get rich.</span>
</p>
</div>
Expand Down
6 changes: 4 additions & 2 deletions examples/intro-original-language.xml
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
<tt xmlns="http://www.w3.org/ns/ttml"
xmlns:ttm="http://www.w3.org/ns/ttml#metadata"
xmlns:ttp="http://www.w3.org/ns/ttml#parameter"
xmlns:daptm="http://www.w3.org/ns/ttml/profile/dapt#metadata"
xml:lang="fr"
ttp:contentProfiles="http://www.w3.org/ns/ttml/profile/dapt1.0/content"
xml:lang="fr"
daptm:langSrc="fr"
daptm:workflowType="dubbing"
daptm:scriptType="originalTranscript">
<head>
Expand All @@ -14,7 +16,7 @@
</head>
<body>
<div begin="10s" end="13s">
<p daptm:langSrc="original" ttm:agent="character_1">
<p ttm:agent="character_1">
<span>Et c'est grâce à ça qu'on va devenir riches.</span>
</p>
</div>
Expand Down
2 changes: 1 addition & 1 deletion examples/intro-script-with-embedded-audio.xml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
...
<div begin="25s" end="28s">
<p daptm:langSrc="original">
<p>
<animate begin="0.0s" end="0.3s" tta:gain="1;0.39" fill="freeze"/>
<animate begin="2.7s" end="3s" tta:gain="0.39;1"/>
<span begin="0.3s" end="2.7s">
Expand Down
5 changes: 3 additions & 2 deletions examples/intro-script-with-gain.xml
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
<tt ...
daptm:workflowType="audioDescription"
daptm:scriptType="asRecorded"
xml:lang="en">
xml:lang="en"
daptm:langSrc="">
...
<div begin="25s" end="28s">
<p daptm:langSrc="original">
<p>
<animate begin="0.0s" end="0.3s" tta:gain="1;0.39" fill="freeze"/>
<animate begin="2.7s" end="3s" tta:gain="0.39;1"/>
<span begin="0.3s" end="2.7s">
Expand Down
2 changes: 1 addition & 1 deletion examples/intro-script-with-speak.xml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
...
<div begin="18s" end="20s">
<p daptm:langSrc="original">
<p>
<span tta:speak="normal">
The woman pulls the tiller and the boat turns.</span>
</p>
Expand Down
9 changes: 5 additions & 4 deletions examples/intro-times-and-text.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,18 @@
xmlns:daptm="http://www.w3.org/ns/ttml/profile/dapt#metadata"
xmlns:xml="http://www.w3.org/XML/1998/namespace"
ttp:contentProfiles="http://www.w3.org/ns/ttml/profile/dapt1.0/content"
xml:lang="en"
daptm:langSrc=""
daptm:workflowType="audioDescription"
daptm:scriptType="preRecording"
xml:lang="en">
daptm:scriptType="preRecording">
<body>
<div begin="10s" end="13s">
<p daptm:langSrc="original">
<p>
A woman climbs into a small sailing boat.
</p>
</div>
<div begin="18s" end="20s">
<p daptm:langSrc="original">
<p>
The woman pulls the tiller and the boat turns.
</p>
</div>
Expand Down
3 changes: 2 additions & 1 deletion examples/intro-top-level.xml
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
<tt xmlns="http://www.w3.org/ns/ttml"
xmlns:ttp="http://www.w3.org/ns/ttml#parameter"
xmlns:daptm="http://www.w3.org/ns/ttml/profile/dapt#metadata"
xml:lang="en"
ttp:contentProfiles="http://www.w3.org/ns/ttml/profile/dapt1.0/content"
xml:lang="en"
daptm:langSrc="en"
daptm:workflowType="dubbing"
daptm:scriptType="originalTranscript">
<head>
Expand Down
Loading

0 comments on commit 8d16753

Please sign in to comment.