Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note use for no character identifier #208

Merged
merged 3 commits into from
Feb 15, 2024

Conversation

nigelmegitt
Copy link
Contributor

@nigelmegitt nigelmegitt commented Jan 31, 2024

Closes #200 and #188.


Preview | Diff

Copy link
Contributor

@cconcolato cconcolato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the sentence:
"In Dubbing Scripts, it is necessary to identify each character in the programme. This is done with a Character object which has the following properties:"

I wonder if this should be changed to
"A character in the programme can be described using a Character object which has the following properties:."
Avoid "in Dubbing Scripts" because it could also be used in "Audio Descriptions"?
Avoid "it is necessary" which is too close to a normative statement.

@nigelmegitt nigelmegitt merged commit 4e5ca8a into main Feb 15, 2024
2 checks passed
@nigelmegitt nigelmegitt deleted the issue-0200-note-zero-character-usage branch February 15, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants