Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Folded Over from Device Posture #100

Merged
merged 1 commit into from
Apr 4, 2023
Merged

Remove Folded Over from Device Posture #100

merged 1 commit into from
Apr 4, 2023

Conversation

supo2co
Copy link
Contributor

@supo2co supo2co commented Mar 2, 2022

Remove the Folded Over posture because it has 2 meanings as described.
The document references "tent-mode" which typically means the device is propped up like a tent. Tent mode does not require a secondary display, consider a Samsung Galaxy Fold that is propped open a little like an alarm clock.

A folded over position would be very challenging for developers to support generally. If it is implemented consistently with the other APIs this means that developers will need to manually split and transform their content.

Closes #???

The following tasks have been completed:

  • Modified Web platform tests (link to pull request)

Implementation commitment:


💥 Error: 500 Internal Server Error 💥

PR Preview failed to build. (Last tried on Apr 3, 2023, 9:54 PM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 Spec Generator - Spec Generator is the web service used to build specs that rely on ReSpec.

🔗 Related URL

🕵️‍♀️  That doesn't seem to be a ReSpec document. Please check manually: https://labs.w3.org/spec-generator/uploads/Wc3vSu/index.html?isPreview=true%3FisPreview%3Dtrue&publishDate=2023-04-03

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

Remove the Folded Over posture because it has 2 meanings as described.
The document references "tent-mode" which typically means the device is propped up like a tent.   Tent mode does not require a secondary display, consider a Samsung Galaxy Fold that is propped open a little like an alarm clock.

A folded over position would be very challenging for developers to support generally.  If it is implemented consistently with the other APIs this means that developers will need to manually split and transform their content.
@supo2co
Copy link
Contributor Author

supo2co commented Mar 2, 2022

For reference, I work on the WindowManager Jetpack library for Android. We had a similar concept initially but removed it for the reasons described.

@darktears
Copy link
Contributor

I think we need to ask @diekus what they think about it. The Surface Duo doesn't support the tent mode but there was discussions about it.

Yes developers will have to adapt their content (just like other postures) but it's an opt-in feature, aka enhancement. I'm not opposed to remove it, we can always add it later. But we shouldn't assume that foldables would never be able to do 360 and thus could provide a tent mode (with dedicated content on each segment).

@supo2co
Copy link
Contributor Author

supo2co commented Sep 15, 2022

It is true that devices might be able to fold over eventually support "tent mode" but exposing it through a single window would make it very challenging to adopt since developers would need to cut and rotate their views and keep them in sync.

@darktears
Copy link
Contributor

darktears commented Sep 15, 2022

That's a fair assumption if you want to provide content on the two segments. Now the folded over has a good semantic in the case of a foldable device capable of 360 hinge: it means the device is in tent mode on the table and meant to be interacted differently (independently of the content being shown in the back segment) than "folded" or "continous", likely without keyboard or mouse because the keyboard is popped out and sit on the table (thinking beyond phones here).

@supo2co
Copy link
Contributor Author

supo2co commented Sep 15, 2022

My understanding is this API would apply to when a fold intersects a single window. It isn't really about the device. The content shown on the back is tied to the content shown on the front.

@darktears
Copy link
Contributor

At TPAC we decided to remove the folder-over posture. We can always re-add it in the future.

@supo2co
Copy link
Contributor Author

supo2co commented Sep 15, 2022

Ack, has it already been removed / should I just close this PR?

@darktears
Copy link
Contributor

darktears commented Sep 16, 2022

No @kenchris or @anssiko will merge it. I was just letting you know.

Copy link
Member

@diekus diekus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no device that currently supports the folded-over posture. Considering it can be easily added if a device required this it makes sense to remove it for now.

@supo2co
Copy link
Contributor Author

supo2co commented Dec 9, 2022

@kenchris do you mind reviewing and merging if this is ok?

@supo2co supo2co closed this by deleting the head repository Mar 31, 2023
@supo2co supo2co reopened this Apr 3, 2023
@kenchris kenchris merged commit bb22fd0 into w3c:gh-pages Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants