editorial: Reorganize internal slots into different sections #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In w3c#152, it was reported that the `[[PostureOverride]]` slot was confusing, and readers could end up thinking that its `null` value could be exposed to script, which is not the case (this internal slot is only used internally in calculations that result in a DevicePostureType). To avoid confusion: - Rename the "Internal slots" section to "Extensions to the Document interface", which is similar to what we already have for the Navigator interface. - Move the `[[PostureOverride]]` slot's definition and the addition of internal slots to top-level traversables to the Automation section, and add a sentence explaining the values are not exposed to script directly. While here, do some proof-reading in the "Extensions to the Document interface" section. Fixes w3c#152
|
This is great! LGTM |
darktears
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #152, it was reported that the
[[PostureOverride]]slot was confusing, and readers could end up thinking that itsnullvalue could be exposed to script, which is not the case (this internal slot is only used internally in calculations that result in a DevicePostureType).To avoid confusion:
[[PostureOverride]]slot's definition and the addition of internal slots to top-level traversables to the Automation section, and add a sentence explaining the values are not exposed to script directly.While here, do some proof-reading in the "Extensions to the Document interface" section.
Fixes #152
Preview | Diff