-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PermissionState is already defined in Permission API #82
Comments
WebKit used |
is there any reason not to re-use |
Loop in @cdumez to comment on WebKit implementation. @reillyeon for Chromium. Implementations that ship with |
I don't really have an opinion here. The name of the enum is not Web-exposed so changing it to whatever would be fine. WebKit does not support for permission API but reusing PermissionState from that spec would equally be fine and would also not require any code change on our side. Note that technically, I copied the Notification API and that one does not use the enum from the Permission API either: It does use a less generic name for the enum though. |
Thanks @cdumez for confirming WebKit would be fine with this spec re-using the Chromium CL (not merged) defines This issue is now on the F2F agenda. |
Discussed at TPAC 2019 F2F. Resolved to adopt the PermissionState enum from the Permissions API specification. |
I've sent #88 to fix this. |
The spec defines an enum with the name
PermissionState
- this conflicts with the name used in the Permission API.The text was updated successfully, but these errors were encountered: