Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed ABNF for method-specific-id of DID Syntax #334

Merged
merged 1 commit into from
Jul 3, 2020
Merged

Fixed ABNF for method-specific-id of DID Syntax #334

merged 1 commit into from
Jul 3, 2020

Conversation

Crenshinibon
Copy link
Contributor

@Crenshinibon Crenshinibon commented Jun 25, 2020 •
edited by pr-preview bot
Loading

See #333

Preview | Diff

@iherman
Copy link
Member

iherman commented Jun 25, 2020

@peacekeeper @msporny I guess this is a non-substantive change, so I will release the IPR lock.

@iherman
Copy link
Member

iherman commented Jun 25, 2020

Marked as non substantive for IPR from ash-nazg.

@msporny
Copy link
Member

msporny commented Jun 25, 2020

@peacekeeper @msporny I guess this is a non-substantive change, so I will release the IPR lock.

Yes, it's a bug fix.

Good catch and thank you @Crenshinibon! :)

talltree
talltree approved these changes Jun 25, 2020
View reviewed changes
Copy link
Contributor

@talltree talltree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch on this bug!

@Crenshinibon
Copy link
Contributor Author

Is there anything I need to do? I was just wondering, that the bug still exists in the Specs.

@msporny
Copy link
Member

msporny commented Jun 29, 2020

Is there anything I need to do? I was just wondering, that the bug still exists in the Specs.

No, you don't need to do anything else. We're waiting on a 7 day timeout before we can do the merge. There are 98 people in the Working Group... one of them might have additional thoughts on this PR (even though it is almost certainly a bug fix). We give those people some time to check it out before merging.

3 days left and then we'll merge your fix in.

msporny
msporny approved these changes Jul 3, 2020
View reviewed changes
Copy link
Member

@msporny msporny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normative, bug fix, multiple reviews, no objections, merging.

@msporny msporny merged commit 2c9e627 into w3c:master Jul 3, 2020
peacekeeper added a commit to decentralized-identity/did-common-java that referenced this pull request Jul 17, 2020
@peacekeeper
fix: Support for latest syntax, per w3c/did-core#334
f9be99b 
Signed-off-by: Markus Sabadello <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talltree talltree talltree approved these changes

@peacekeeper peacekeeper peacekeeper approved these changes

@msporny msporny msporny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Crenshinibon @iherman @msporny @peacekeeper @talltree