Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External resources should be loaded securely #2263

Closed
npdoty opened this issue May 10, 2022 · 1 comment · Fixed by #2299
Closed

External resources should be loaded securely #2263

npdoty opened this issue May 10, 2022 · 1 comment · Fixed by #2299
Labels
EPUB33 Issues addressed in the EPUB 3.3 revision security-needs-resolution Issue the security Group has raised and looks for a response on. Spec-ReadingSystems The issue affects the EPUB Reading Systems 3.3 Recommendation Topic-PublicationResources The issue affects support for publications resources

Comments

@npdoty
Copy link

npdoty commented May 10, 2022

External resources should be loaded securely, for example over HTTPS. Otherwise, threats would also include any network attacker when the book is being read (even separate from whether the book contents itself were securely transferred). This is currently a non-normative recommendation, but seems like a good candidate for a normative recommendation.

Network attackers are not currently described in the threat model of either the core or rs specs.

@npdoty npdoty added security-tracker Group bringing to attention of security, or tracked by the security Group but not needing response. security-needs-resolution Issue the security Group has raised and looks for a response on. labels May 11, 2022
@w3cbot w3cbot removed the security-tracker Group bringing to attention of security, or tracked by the security Group but not needing response. label May 11, 2022
@mattgarrish mattgarrish added Spec-ReadingSystems The issue affects the EPUB Reading Systems 3.3 Recommendation Topic-PublicationResources The issue affects support for publications resources labels May 20, 2022
@iherman iherman added the Agenda+ Issues that should be discussed during the next working group call. label May 23, 2022
@iherman
Copy link
Member

iherman commented May 27, 2022

The issue was discussed in a meeting on 2022-05-26

List of resolutions:

View the transcript

1.2. External Resources should be loaded securely.

See github issue epub-specs#2263.

See github pull request epub-specs#2299.

Dave Cramer: this issue comes with this PR.
… this is around remote resources, and recommended that they be served over HTTPS.
… avoiding person in the middle and other such network attacks.

Dan Lazin: my only concern is the PR itself is not super clear in its language.
… "RS may not load resources".
… what we mean is there is a chance RS may not load.
… I'll do a pass.

Dave Cramer: this is SHOULD level, so would we test whether a remote resource is served via HTTP, and that would result in a warning from epubcheck?.

Matt Garrish: yes, that is what I would expect.

Dave Cramer: this could affect existing content, but I expect it would be rare.

Matt Garrish: generally the direction of the web is HTTPS too.
… this will cause some warnings, but security outweighs. We should move in the direction of the web.

Dave Cramer: using backwards compatibility as reason not to fix security issue isn't where we want to be.

Proposed resolution: Approve PR 2299, close issue 2265. (Wendy Reid)

Brady Duga: +1.

Wendy Reid: +1.

Shinya Takami (高見真也): +1.

Matthew Chan: +1.

Masakazu Kitahara: +1.

Dan Lazin: +1.

Dave Cramer: +1.

Toshiaki Koike: +1.

Matt Garrish: +1.

Resolution #2: Approve PR 2299, close issue 2265.

@mattgarrish mattgarrish added EPUB33 Issues addressed in the EPUB 3.3 revision and removed Agenda+ Issues that should be discussed during the next working group call. labels Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EPUB33 Issues addressed in the EPUB 3.3 revision security-needs-resolution Issue the security Group has raised and looks for a response on. Spec-ReadingSystems The issue affects the EPUB Reading Systems 3.3 Recommendation Topic-PublicationResources The issue affects support for publications resources
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants