Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of html base element discouraged #1271

Closed
mattgarrish opened this issue Jul 12, 2021 · 0 comments
Closed

Use of html base element discouraged #1271

mattgarrish opened this issue Jul 12, 2021 · 0 comments
Labels
spec: EPUB 3.3 Impacting the support of EPUB 3.3 status: completed Work completed, can be closed
Milestone
v5.0.0-beta

Comments

@mattgarrish
Copy link
Member

Authors are advised not to use the element, so maybe an info message could be emitted if it's found.

See w3c/epub-specs#1699
@mattgarrish mattgarrish added the spec: EPUB 3.3 Impacting the support of EPUB 3.3 label Jul 12, 2021
@rdeltour rdeltour added the status: accepted Ready to be further processed label Nov 13, 2021
@rdeltour rdeltour added this to the v5.0.0-beta-1 milestone Nov 13, 2021
@rdeltour rdeltour added status: ready for implem The issue is ready to be implemented status: in progress The issue is being implemented by the development team and removed status: accepted Ready to be further processed status: ready for implem The issue is ready to be implemented labels Jan 23, 2022
rdeltour added a commit that referenced this issue Jul 8, 2022
@rdeltour
feat: check discouraged HTML elements (base, rp, embed)
afb28cb 
EPUB 3.3 discourages the use of the following elements:
- `base`
- `rp`
- `embed`

This commits:
- adds a new check HTM-055 to report all uses of discouraged elements
- add tests for discouraged constructs
- tweak existing tests that used discouraged constructs

Fix #1271
@rdeltour rdeltour added status: completed Work completed, can be closed and removed status: in progress The issue is being implemented by the development team labels Sep 22, 2022
@rdeltour rdeltour mentioned this issue Dec 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
spec: EPUB 3.3 Impacting the support of EPUB 3.3 status: completed Work completed, can be closed
Projects
None yet
Milestone
v5.0.0-beta
Development

No branches or pull requests
2 participants
@rdeltour @mattgarrish