Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict obfuscation to fonts #1291

Closed
mattgarrish opened this issue Dec 17, 2021 · 0 comments
Closed

Restrict obfuscation to fonts #1291

mattgarrish opened this issue Dec 17, 2021 · 0 comments
Assignees
@rdeltour
Labels
spec: EPUB 3.3 Impacting the support of EPUB 3.3 status: completed Work completed, can be closed
Milestone
v5.0.0-beta

Comments

@mattgarrish
Copy link
Member

mattgarrish commented Dec 17, 2021 •
edited
Loading

Obfuscated resources must be core media type fonts now.

So if the EncryptionMethod element specifies "http://www.idpf.org/2008/embedding", then the resource in the CipherReference has to be checked against its manifest media type declaration.

See w3c/epub-specs#1873
@mattgarrish mattgarrish added the spec: EPUB 3.3 Impacting the support of EPUB 3.3 label Dec 17, 2021
@rdeltour rdeltour self-assigned this Dec 17, 2021
@rdeltour rdeltour added this to the v5.0.0 milestone Dec 17, 2021
@rdeltour rdeltour added the status: accepted Ready to be further processed label Dec 17, 2021
@rdeltour rdeltour modified the milestones: v5.0.0, v5.0.0-beta-1 Jan 23, 2022
@rdeltour rdeltour added status: ready for implem The issue is ready to be implemented status: in progress The issue is being implemented by the development team and removed status: accepted Ready to be further processed status: ready for implem The issue is ready to be implemented labels Jan 23, 2022
rdeltour added a commit that referenced this issue Jul 8, 2022
@rdeltour
feat: restrict obfuscation to font core media types
a229edf 
EPUB 3.3 explicitly restricts the font obfuscation algorithm to resources
being declared as dont Core Media Types.

This commit:
- registers obfuscated resources to the OCFPackage when parsing the
  `encyrption.xml` file (with parsing location)
- checks that if obfuscated resources are declared in Package Documents,
  they have a font core media type
- add and tweak tests

Fix #1291
@rdeltour rdeltour added status: completed Work completed, can be closed and removed status: in progress The issue is being implemented by the development team labels Sep 22, 2022
@rdeltour rdeltour mentioned this issue Dec 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rdeltour rdeltour

Labels
spec: EPUB 3.3 Impacting the support of EPUB 3.3 status: completed Work completed, can be closed
Projects
None yet
Milestone
v5.0.0-beta
Development

No branches or pull requests
2 participants
@rdeltour @mattgarrish