Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

renditionLayout, referencedItems, navigationOrder, isHTML5 incorrect in JSON output #1515

Closed
nekennedy opened this issue May 4, 2023 · 1 comment · Fixed by #1525
Closed

renditionLayout, referencedItems, navigationOrder, isHTML5 incorrect in JSON output #1515

nekennedy opened this issue May 4, 2023 · 1 comment · Fixed by #1525
Assignees
@rdeltour
Labels
status: has PR The issue is being processed in a pull request type: bug The issue describes a bug
Milestone
v5.1.0

Comments

@nekennedy
Copy link

The json output from 5.0.1 is much closer to 4.2.6, but there are still some missing elements.
Again, we don't use this output in our ebook production tools so it's a low priority.

  • The most important potential issue is renditionLayout appearing as reflowable for pre-paginated content.
  • Some elements are still coming through as null/false/empty: "navigationOrder" : null, "isHTML5" : false, "referencedItems" : [ ]
  • The list of 'embeddedFonts' has moved to 'refFonts'. Not sure if this is a feature or a bug but the fonts in our case are actually embedded.
@nekennedy
Copy link
Author

@gregoriopellegrino tagging you just in case it's important to your process!

@karenhanson karenhanson mentioned this issue Jun 12, 2023
Closed
@rdeltour rdeltour self-assigned this Jun 30, 2023
@rdeltour rdeltour added type: bug The issue describes a bug status: accepted Ready to be further processed labels Jul 5, 2023
@rdeltour rdeltour added this to the Next maintenance release milestone Jul 5, 2023
rdeltour added a commit that referenced this issue Jul 6, 2023
@rdeltour
fix: remove undefined isHTML5 field from the JSON report
00b1d20 
See #1515
rdeltour added a commit that referenced this issue Jul 6, 2023
@rdeltour
fix: remove undefined script-related fields from the JSON report
1931d73 
This commit remove the following properties from the JSON report, as these were no longer set by EPUBCheck:
- `scriptSrc`
- `scriptTag`
- `scriptInline`

The report now on says if an item is scripted or not.

See #1515
rdeltour added a commit that referenced this issue Jul 6, 2023
@rdeltour
fix: remove undefined navigationOrder field from the JSON report
39234a6 
This commit remove the `navigationOrder` field from the JSON report, as this was no longer set by EPUBCheck.

Navigation order consistency is better checked manually or with help of external tools.

See #1515
rdeltour added a commit that referenced this issue Jul 6, 2023
@rdeltour
fix: properly set the rendition fields in the JSON report
da643e4 
See #1515
rdeltour added a commit that referenced this issue Jul 6, 2023
@rdeltour
fix: properly set the referencedItems field in the JSON report
7804c78 
See #1515
rdeltour added a commit that referenced this issue Jul 6, 2023
@rdeltour
fix: properly set font fields in the JSON report
8575a6b 
All fonts were added to the `refFonts` field, even when embedded. This commit fixes that.

See #1515
Fix #1519
@rdeltour rdeltour mentioned this issue Jul 6, 2023
Merged
@rdeltour rdeltour added status: has PR The issue is being processed in a pull request and removed status: accepted Ready to be further processed labels Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rdeltour rdeltour

Labels
status: has PR The issue is being processed in a pull request type: bug The issue describes a bug
Projects
None yet
Milestone
v5.1.0
Development

Successfully merging a pull request may close this issue.

Fix a variety of JSON report issues w3c/epubcheck
2 participants
@rdeltour @nekennedy