Allow doc-epigraph and doc-cover #1142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI, I found the removal of doc-cover came from this issue: w3c/html-aria#230 I've opened a new issue to have it added back, which is why this was not an error in the last version of epubcheck but is now: w3c/html-aria#230 |
|
I've opened an issue to have these added to the formal schemas: validator/validator#966 |
…he PR to the validator code base has been accepted
rdeltour
approved these changes
Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1019 and #1141 by overriding the section attrs definition to allow doc-epigraph.
I also discovered that doc-cover is not allowed on img, so it adds an override for that. It's not currently listed in the ARIA in HTML document.
I couldn't find any more elegant way to add these semantics, as there's no way to inject them into the allowed roles as the lists are element-specific.
Both these patches should only be temporary, though, as the HTML schemas should eventually be updated to allow them.