Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix #647] Update Saxon dependency from 9.5.1-5 to 9.6.0-10 #767

Merged
merged 2 commits into from
Sep 18, 2017
Merged

[fix #647] Update Saxon dependency from 9.5.1-5 to 9.6.0-10 #767

merged 2 commits into from
Sep 18, 2017

Conversation

mkraetke
Copy link
Contributor

@mkraetke mkraetke commented Jun 7, 2017

Update Saxon with respect of the latest Saxon API changes.

@tofi86 tofi86 changed the title Update epubcheck from Saxon 9.5.1-5 to 9.6.0-7 [fix #647] Update Saxon dependency from 9.5.1-5 to 9.6.0-7 Jun 7, 2017
@tofi86 tofi86 requested review from rdeltour and tofi86 June 7, 2017 11:23
@tofi86 tofi86 added this to the 4.1.0 milestone Jun 7, 2017
@tofi86
Copy link
Collaborator

tofi86 commented Jun 7, 2017

Shall we at least update Saxon 9.6 to the latest maintenance release 9.6.0-10?

@mkraetke did you ever test with a newer version?

@mkraetke
Copy link
Contributor Author

mkraetke commented Jun 7, 2017

We experienced some issues with versions later than 9.6.0.7, so we consider this version as stable.

@tofi86 tofi86 added the status: needs review Needs to be reviewed by a team member before further processing label Aug 15, 2017
@tofi86
Copy link
Collaborator

tofi86 commented Sep 17, 2017

@rdeltour gave his okay about updating the saxon dependency:

On 25.08.17 at 20:10 Romain wrote:

Tobias: about the Saxon dependency issue, I was just worried that a
maintenance release would break integrations for systems that still use
the older Saxon version. That said, Saxon 9.5 is pretty old now, so I
guess we can be blunt and update to 9.6.

  • Old version 9.5.1-5 was released in march 2014.
  • Proposed version 9.6.0-7 was released in august 2015.
  • Latest version of 9.6 branch (9.6.0-10) was released in December 2016.

Despite @mkraetke writing that they experienced issues with newer versions than 9.6.0-7 I'd like to update the saxon dependency at least to the latest version of 9.6 branch.
All unit tests for this are giving good results.

@tofi86 tofi86 removed the status: needs review Needs to be reviewed by a team member before further processing label Sep 17, 2017
@tofi86 tofi86 changed the title [fix #647] Update Saxon dependency from 9.5.1-5 to 9.6.0-7 [fix #647] Update Saxon dependency from 9.5.1-5 to 9.6.0-10 Sep 17, 2017
@tofi86 tofi86 merged commit 8f56c01 into w3c:master Sep 18, 2017
@tofi86
Copy link
Collaborator

tofi86 commented Sep 18, 2017

Thanks for your contribution, @mkraetke 👏 🎉

@mkraetke
Copy link
Contributor Author

Glad to help, thank you for your awesome work guys!

@rdeltour rdeltour removed their request for review November 17, 2017 15:50
@rdeltour rdeltour added type: improvement The issue suggests an improvement of an existing feature and removed type: improvement The issue suggests an improvement of an existing feature labels Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: improvement The issue suggests an improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants