Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: callbacks are not EventHandlers #39

Merged
merged 1 commit into from
May 22, 2020
Merged

fix: callbacks are not EventHandlers #39

merged 1 commit into from
May 22, 2020

Conversation

marcoscaceres
Copy link
Member

@marcoscaceres marcoscaceres commented May 21, 2020 •
edited by pr-preview bot
Loading

Closes #24

The following tasks have been completed:

  • Modified Web platform tests: there are not tests in WPT for this, thankfully.

Implementation commitment:

  • WebKit
  • Chromium
  • Gecko

Checked all three browsers, no one supports what was in the spec.

💥 Error: 403 Forbidden 💥

PR Preview failed to build. (Last tried on May 21, 2020, 6:32 AM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 HTML Diff Service - The HTML Diff Service is used to create HTML diffs of the spec changes suggested in a pull request.

🔗 Related URL


<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en-US">
<head><title>HTML Diff service</title>
<link rel="stylesheet" href="http://www.w3.org/StyleSheets/base" />
</head>
<body>

<p><a href="http://www.w3.org/"><img src="http://www.w3.org/Icons/w3c_home" alt="W3C"/></a> <a href="http://www.w3.org/2003/Editors">W3C Editors homepage</a></p>

<h1>Create Diff between HTML pages</h1>

<p style='color:#FF0000'>An error (403 Forbidden) occured trying to get <a href='https://pr-preview.s3.amazonaws.com/w3c/geolocation-api/pull/39/3341e1e.html'>https://pr-preview.s3.amazonaws.com/w3c/geolocation-api/pull/39/3341e1e.html</a>.</p>

<form method="GET">
<p>Address of reference document: <input name="doc1" type="url" value="https://pr-preview.s3.amazonaws.com/w3c/geolocation-api/pull/39/3341e1e.html" style="width:100%"/></p>
<p>Address of new document: <input name="doc2" value="https://pr-preview.s3.amazonaws.com/w3c/geolocation-api/pull/39.html"  style="width:100%"/></p>
<p><input type="submit" value="get Diff"/></p>
</form>

<p><strong>Tip</strong>: if the document uses the W3C convention on linking to its previous version, you can specify only the address of the new document — the previous link will be automatically detected.</p>
<h2>Diff markings</h2>
<p>This service relies on <a href="https://www.gnu.org/software/diffutils/">GNU diff</a>. The found differences are roughly marked as follow:
<ul>
<li>deleted text is shown in pink with down-arrows (as styled for a &lt;del> element)</li>
<li>where there is replacement, it’s shown in green with bi-directional arrows,</li>
<li>where there is newly inserted text, it’s yellow with up arrows (&lt;ins> element)</li>
</ul>
<address>
script $Revision$ of $Date$<br />
by <a href="http://www.w3.org/People/Dom/">Dominique Hazaël-Massieux</a><br />based on <a href="https://github.com/w3c/htmldiff-ui/blob/master/htmldiff.pl">Shane McCarron’ Perl script</a> wrapped in a <a href="https://github.com/w3c/htmldiff-ui/blob/master/htmldiff">Python CGI</a>
</address>
</body>
</html>

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

@marcoscaceres
Copy link
Member Author

@foolip, this should address #24 by just removing mention of handleEvent. Let me know what you think.

@marcoscaceres marcoscaceres merged commit 33e5ae6 into gh-pages May 22, 2020
@marcoscaceres marcoscaceres deleted the callback branch May 22, 2020 05:30
@foolip
Copy link
Member

foolip commented May 25, 2020

Thanks for the fix, @marcoscaceres!

@marcoscaceres marcoscaceres mentioned this pull request Jun 4, 2020
Closed
This was referenced Jun 24, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reillyeon reillyeon reillyeon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Callbacks functions don't have a handleEvent operation
3 participants
@marcoscaceres @foolip @reillyeon