-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only update position if document is showing #67
Conversation
Sent a patch to Gecko as part of https://bugzilla.mozilla.org/show_bug.cgi?id=1653549 |
index.html
Outdated
object</a>'s [=environment settings object / responsible | ||
document=]. | ||
</li> | ||
<li>If |document| is [=Document/visible=] and the <dfn>new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@reillyeon ... Alternative was just:
If |document| is [=Document/hidden=], return.
Though I feel this was more clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I'm going to flip it...
I just realized that this is not enough... I'll update this and send again. |
Ok, did a deep dive and did some more testing. This requires a fairly hefty rewrite of the spec. Basically, we need to wire up visibility change listeners for when the methods are called. All the timing stuff is also affected, because the position request happens after the document becomes visible again. |
will send again after rewrite... |
Just for the record, Chromium doesn't implement the timing requirements around permissions but I think that should qualify as a bug as the requirements make sense. |
As part of exploring of adding this to Gecko, Edgar identified some inconsistency around how visibility is handled between Chrome and Safari... I'll report back once I have a better handle on what's going on. |
Closes #48
The following tasks have been completed:
Implementation commitment:
Preview | Diff