Add encryption scheme to KeySystemTrackConfiguration #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tidoust I need to reference the editors draft of the EME spec. Took a stab at it here but I'll be shocked if I've got it totally right. @joeyparrish lmk if this as expected @vi-dot-cpp @mounirlamouri for co-editor review |
joeyparrish
approved these changes
Jan 23, 2020
There was a problem hiding this comment.
Looks good to me. Thanks!
Also, re: "I need to reference the editors draft of the EME spec. Took a stab at it here but I'll be shocked if I've got it totally right." ... I checked all the EME draft links in the preview of this PR, and they all seem to go to the right places. So I think you did get right!
mounirlamouri
approved these changes
Jan 24, 2020
|
Thanks for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encryption scheme is now part of the EME editors draft. This patch updates MediaCapabilities to include it alongside robustness.
Fixes #100
Preview | Diff