Update introduction section #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes mention of Media Playback Quality, which isn't in scope, and display capability detection is solved elsewhere
aboba
reviewed
Nov 27, 2023
Co-authored-by: Marcos Cáceres <[email protected]>
Co-authored-by: Marcos Cáceres <[email protected]>
Co-authored-by: Marcos Cáceres <[email protected]>
index.bs
Outdated
| is the number of bits used to encode a second of the audio track. | ||
| </p> | ||
|
|
||
| <p> | ||
| The <dfn for='AudioConfiguration' dict-member>samplerate</dfn> | ||
| represents the samplerate of the audio track in. The samplerate is the | ||
| number of samples of audio carried per second. samplerate is only | ||
| member represents the samplerate of the audio track in. The samplerate |
There was a problem hiding this comment.
Suggested change
| member represents the samplerate of the audio track in. The samplerate | |
| member represents the sample rate of the audio track in. The sample rate |
There was a problem hiding this comment.
We also need to remove "in" here. I'll fix this.
| represents the samplerate of the audio track in. The samplerate is the | ||
| number of samples of audio carried per second. samplerate is only | ||
| member represents the samplerate of the audio track in. The samplerate | ||
| is the number of samples of audio carried per second. samplerate is only |
There was a problem hiding this comment.
Suggested change
| is the number of samples of audio carried per second. samplerate is only | |
| is the number of samples of audio carried per second. sample rate is only |
There was a problem hiding this comment.
samplerate here refers to the dictionary member, so i think shouldn't change.
marcoscaceres
approved these changes
Jul 18, 2024
Co-authored-by: Marcos Cáceres <[email protected]>
chrisn
commented
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the introduction to explain that display capability detection happens elsewhere, and removes mention of Media Playback Quality.
It also fixes a few grammatical issues I found elsewhere in the spec.
Preview | Diff