Clarify pan/tilt/zoom constraints (#225) #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@guidou Does that look good to you as well? |
guidou
reviewed
May 26, 2020
eehakkin
force-pushed
the
feature/ptz-clarify
branch
from
c0beae4
to
50de87b
Compare
riju
approved these changes
May 28, 2020
|
lgtm, but please add @alvestrand as reviewer too |
guidou
approved these changes
May 28, 2020
|
@alvestrand : Harald, PTAL. |
alvestrand
approved these changes
Jun 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this clarifies the spec and resolves the concerns raised in #225.
There are no functional or algorithmic changes as that is the consensus reached during discussion in #225 as I understood.