Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the type of Constrainable Properties #945

Closed
jan-ivar opened this issue Mar 27, 2023 · 1 comment · Fixed by #948
Closed

Clarify the type of Constrainable Properties #945

jan-ivar opened this issue Mar 27, 2023 · 1 comment · Fixed by #948

Comments

@jan-ivar
Copy link
Member

This spec still conflates constraints and constrainable properties in places (the former are applied to the latter).

One instance is its description of types of constrainable properties (skip deviceId and groupId for now due to #941, and skip integer ones due to #944):

image

This is wrong and misleading.

The type of the constrainable property, the property being constrained on, is a simple type, not a Constrain* dictionary.

E.g. the type of the constrainable property frameRate is double, not ConstrainDouble.

This didn't used to matter, but with #766 it is causing confusion, e.g. in #933.

@jan-ivar jan-ivar self-assigned this Mar 27, 2023
@jan-ivar
Copy link
Member Author

I'm marking this as editorial as these mistakes seem attributable to editing of the spec over time to move away from "constraints" as the primary concept, to "constrainable properties" being the primary concept, and at some point this was probably a list of constraints, not constrainable properties (points to #258).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant