Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fitness distance for bool placeholder & constraints not supported by device. #766

Merged
merged 7 commits into from
Jan 28, 2021
Merged

Fitness distance for bool placeholder & constraints not supported by device. #766

merged 7 commits into from
Jan 28, 2021

Conversation

jan-ivar
Copy link
Member

@jan-ivar jan-ivar commented Jan 14, 2021 •
edited by pr-preview bot
Loading

Replaces #742 as partial fix to w3c/mediacapture-image#256.

Preview | Diff

@jan-ivar jan-ivar self-assigned this Jan 14, 2021
@jan-ivar jan-ivar changed the title Unfit Define fitness distance for constraints not supported by a device. Jan 14, 2021
@jan-ivar jan-ivar mentioned this pull request Jan 14, 2021
Closed
@jan-ivar jan-ivar changed the title Define fitness distance for constraints not supported by a device. Fitness distance for bool variant and constraints not supported by a device. Jan 14, 2021
@jan-ivar jan-ivar changed the title Fitness distance for bool variant and constraints not supported by a device. Fitness distance for bool placeholder & constraints not supported by a device. Jan 14, 2021
@jan-ivar jan-ivar changed the title Fitness distance for bool placeholder & constraints not supported by a device. Fitness distance for bool placeholder & constraints not supported by device. Jan 14, 2021
@jan-ivar
Copy link
Member Author

@riju, @guidou, @eehakkin PTAL.

@jan-ivar jan-ivar mentioned this pull request Jan 15, 2021
Merged
guidou
guidou reviewed Jan 19, 2021
View reviewed changes
getusermedia.html Outdated Show resolved Hide resolved
jan-ivar
jan-ivar commented Jan 19, 2021
View reviewed changes
getusermedia.html Outdated Show resolved Hide resolved
@jan-ivar
Copy link
Member Author

jan-ivar commented Jan 26, 2021 •
edited
Loading

@youennf asked me to test how {facingMode: {exact}} constrains cameras with unknown facing mode, since this PR would define it. Results from this fiddle on desktop:

Browser facingMode: {exact: "user"} getSettings()
Chrome OverconstrainedError facingMode: undefined
Edge OverconstrainedError facingMode: undefined
Firefox OverconstrainedError¹ facingMode: undefined
Safari facingMode: {exact: "user"} succeeded facingMode: undefined

I think these results favor merging the PR as-is, and that we open an issue on webkit to align with the other browsers.

1. Firefox considers "Facetime" cameras on macOS to have facingMode: "user", so instead I verified that exact constraints correctly excluded an attached Logitech camera from the camera picker in the permission prompt, which amounts to the same thing as OverconstrainedError had it been the only camera available.

@henbos henbos merged commit 6b782b5 into w3c:master Jan 28, 2021
@jan-ivar jan-ivar deleted the unfit branch January 28, 2021 15:37
@jan-ivar jan-ivar mentioned this pull request Apr 12, 2021
Closed
blueboxd pushed a commit to blueboxd/chromium-legacy that referenced this pull request Apr 14, 2021
@eehakkin
[PTZ] Simplify fitness distances for PTZ constrainable properties
b6a7545 
This changes pan, tilt and zoom constrainable properties so that for
each them there is a single constrainable property which can be
constrained either with a boolean constraint (resulting in a fitness
distance of 0 or 1) or with a numeric constraint (resulting in a fitness
distance from 0.0 to 1.0).

Spec:
w3c/mediacapture-image#271
w3c/mediacapture-main#766

Change-Id: Iebb0a4f42c518286cefa6b39b2a42f6dbcd30521
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2814545
Commit-Queue: Guido Urdaneta <[email protected]>
Auto-Submit: Eero Häkkinen <[email protected]>
Reviewed-by: Guido Urdaneta <[email protected]>
Cr-Commit-Position: refs/heads/master@{#872352}
@eehakkin eehakkin mentioned this pull request May 5, 2021
Closed
mjfroman pushed a commit to mjfroman/moz-libwebrtc-third-party that referenced this pull request Oct 14, 2022
@eehakkin @copybara-github
[PTZ] Simplify fitness distances for PTZ constrainable properties
db04ad9 
This changes pan, tilt and zoom constrainable properties so that for
each them there is a single constrainable property which can be
constrained either with a boolean constraint (resulting in a fitness
distance of 0 or 1) or with a numeric constraint (resulting in a fitness
distance from 0.0 to 1.0).

Spec:
w3c/mediacapture-image#271
w3c/mediacapture-main#766

Change-Id: Iebb0a4f42c518286cefa6b39b2a42f6dbcd30521
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2814545
Commit-Queue: Guido Urdaneta <[email protected]>
Auto-Submit: Eero Häkkinen <[email protected]>
Reviewed-by: Guido Urdaneta <[email protected]>
Cr-Commit-Position: refs/heads/master@{#872352}
GitOrigin-RevId: b6a7545796bec4c47a1c2b7504c82932fff7a71d
This was referenced Mar 27, 2023
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eehakkin eehakkin eehakkin approved these changes

@guidou guidou guidou approved these changes

@alvestrand alvestrand Awaiting requested review from alvestrand

@youennf youennf Awaiting requested review from youennf

@henbos henbos Awaiting requested review from henbos

Assignees

@jan-ivar jan-ivar

Labels
Editors can integrate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jan-ivar @eehakkin @guidou @youennf @henbos