Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve and fix example for <octave-shift> #554

Open
lemzwerg opened this issue Sep 15, 2024 · 1 comment
Open

Improve and fix example for <octave-shift> #554

lemzwerg opened this issue Sep 15, 2024 · 1 comment

Comments

@lemzwerg
Copy link
Contributor

lemzwerg commented Sep 15, 2024

Here's the current example for <octave-shift>

image

IMHO, it has two major problems.

  • It is incomplete. In particular, it doesn't show where the ending <octave-shift> element should be positioned – probably one of the reasons that lead to the current situation as discussed in `<octave-shift>` issues #552.

  • It uses <offset>, which IMHO is bad. The starting position of the '8va' symbol relative to the associated note head should be fixed and not depend on the layout. In other words, <offset> should be replaced with a relative-x attribute.

    image

    Of course, using <offset> per se is not wrong (and it probably makes sense in some situations if applied to the end of an ottava so that it stops right before a bar line), but I think it would be best if the MusicXML examples also show good practice. BTW, the value -4 of <offset> in the example is meaningless if the value of <divisions> isn't also given or mentioned.

@infojunkie
Copy link

infojunkie commented Sep 15, 2024

I wrote a scraper for the MusicXML examples at https://github.com/infojunkie/musicxml-midi/blob/main/src/js/musicxml-examples.js

I had to create a MusicXML wrapping to convert the examples to actual MusicXML files. While the generated files are all technically passing validation against musicxml.xsd (except for a few that I flagged at #496) I did not verify (and highly doubt) that they make sense semantically.

I do think the examples would be more useful to the community if they included the full MusicXML structures, instead of fragments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants