Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors in examples #496

Closed
infojunkie opened this issue Nov 14, 2023 · 1 comment · Fixed by #534
Closed

Errors in examples #496

infojunkie opened this issue Nov 14, 2023 · 1 comment · Fixed by #534

Comments

@infojunkie
Copy link

At infojunkie/musicxml-midi#40, I am working on extracting the MusicXML examples to use them as test cases.

Part of my script validates each example using xmllint and the 4.0 spec. I found that 5 examples are not validating:

  • accordion-middle-element: Element 'accordion-middle': '' is not a valid value of the atomic type 'accordion-middle'.
  • circular-arrow-element: Element 'circular-arrow': [facet 'enumeration'] The value 'anti-clockwise' is not an element of the set {'clockwise', 'anticlockwise'}.
  • interchangeable-element: Element 'time-relation': This element is not expected. Expected is ( beats ).
  • inversion-element: Element 'inversion': This element is not expected. Expected is ( kind ).
  • voice-element: Element 'tuplet', attribute 'bracket': [facet 'enumeration'] The value 'none' is not an element of the set {'yes', 'no'}.

I'll be submitting a PR to fix these errors.

@mscuthbert
Copy link
Contributor

Thanks -- these look right to me -- I'm going to set up a 4.1 branch and then merge.

mscuthbert added a commit to mscuthbert/musicxml that referenced this issue Aug 2, 2024
This PR is basically the same as Infojunkie's in w3c#497 and fixes w3c#496, but it's set up to run on the new json system which holds the "Ground truth" for musical examples.

Thanks infojunkie!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants