-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: close request if sheet is showing #821
Conversation
@zouhir, not sure if you can confirm this yet, but I guess Edge going forward will rely on Blink's implementation of Payment Request but still use Microsoft Wallet for payments. Is that a valid assumption? If yes, then I can just assume whatever is in Blink will work in Edge, in as far as the API mechanics are concerned (then I don't need to bug you to confirm things 😇 ). |
Added test: |
May or may not, depending on where Chromium ends and Edge begins. Blink is a very thin layer that mostly forwards calls to the browser process, where most of the logic is implemented. The reason for that is we trust the renderer process as little as possible, since it parses and runs arbitrary HTML/JS from the web. |
Thanks @marcoscaceres for checking with me - it is hard for me to confirm at the moment but the scnario you described is what I personally think is ideal for now. generally speaking there is no intent to diverge. I believe in the following couple weeks I will have better comment on this 😊. |
Thanks @zouhir and @rsolomakhin for the details. I'll wait a few days for @aestes to confirm it's ok to make this small change, and there is not some obvious use case we might have overlooked. |
Going to move forward with this. Can revise if @aestes raises any concerns. |
closes #820
The following tasks have been completed:
Implementation commitment:
Optional, impact on Payment Handler spec?
None
Preview | Diff