Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default values for distance and max. #14

Merged
merged 1 commit into from
Jul 11, 2016
Merged

Conversation

riju
Copy link
Contributor

@riju riju commented Jul 11, 2016

Fixes #3, #4.

@anssiko
Copy link
Member

anssiko commented Jul 11, 2016

LGTM, thanks!

I think we want to leave #4 open for discussion to gather further feedback on whether we should make the distinction between near boolean and distance in centimeters more explicit. If they're exposed via the same ProximitySensorReading object, they cannot be unbundled in terms of permissioning etc. Sensor access is requested per sensor instance (in this case ProximitySensor), see https://w3c.github.io/sensors/#request-sensor-access

@anssiko anssiko merged commit 733ea46 into w3c:gh-pages Jul 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants