Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Model section, export permission and policy-controlled feature name #58

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

rakuco
Copy link
Member

@rakuco rakuco commented Oct 26, 2023

  • Move the permissions-policy text to a separate section for clarity.
  • Stop saying "Proximity Sensor a policy-controlled feature" because it does
    not make much sense. The most common way to list features is by saying
    something like "this spec defines a feature identifed by the string
    'foo'". In our case, that string is "proximity-sensor".
  • Define and export the feature identifier above.
  • Explicitly list all data associated with the spec's sensor type using a
    definition list instead of a very long paragraph.
  • Similarly to Define and export "accelerometer" permission accelerometer#67, define and export the "gyroscope"
    permission so that we can eventually link to the permission name from
    https://w3c.github.io/permissions-registry/

Preview | Diff

…re name

* Move the permissions-policy text to a separate section for clarity.
* Stop saying "Proximity Sensor a policy-controlled feature" because it does
  not make much sense. The most common way to list features is by saying
  something like "this spec defines a feature identifed by the string
  'foo'". In our case, that string is "proximity-sensor".
* Define and export the feature identifier above.
* Explicitly list all data associated with the spec's sensor type using a
  definition list instead of a very long paragraph.
* Similarly to w3c/accelerometer#67, define and export the "gyroscope"
  permission so that we can eventually link to the permission name from
  https://w3c.github.io/permissions-registry/
@rakuco rakuco requested a review from anssiko October 26, 2023 09:42
@anssiko anssiko merged commit 576057f into w3c:main Oct 26, 2023
2 checks passed
github-actions bot added a commit that referenced this pull request Oct 26, 2023
SHA: 576057f
Reason: push, by anssiko

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@rakuco rakuco deleted the rewrite-model-section branch October 26, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants