You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Most methods refer to a bytes variable that is not defined. Presumably this should be the internal slot that references the associated byte sequence or null?
The methods don't handle bytes being null. Though perhaps it should never be null and that should instead be handled one layer up? It does seem that data on PushEvent is nullable, though data on PushEventInit is not??? That would match how section 10.4 initializes this.
The text was updated successfully, but these errors were encountered:
Give PushMessageData a clear internal concept to hold the bytes and also make it clear that it cannot be null. None of the methods were prepared to handle it being null and nothing ever creates a PushMessageData object where it is null.
Partially addresses the concerns in #380 and fixes#381.
Give PushMessageData a clear internal concept to hold the bytes and also make it clear that it cannot be null. None of the methods were prepared to handle it being null and nothing ever creates a PushMessageData object where it is null.
Partially addresses the concerns in #380 and fixes#381.
What remains here is making data on PushEventInit nullable (and default to null). That's a normative change that requires changes to implementations, but I think would make sense given the overall desired model.
data
onPushEvent
is nullable, thoughdata
onPushEventInit
is not??? That would match how section 10.4 initializes this.The text was updated successfully, but these errors were encountered: