Add tests for definition extraction #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tidoust
approved these changes
Jun 25, 2020
tests/extract-dfns.js
Outdated
| html: "<dfn id='foo'>Foo</dfn>", | ||
| dfns: [{}] | ||
| }, | ||
| {title: "normalize whitespace and trims text in a simple <dfn>", |
tests/extract-dfns.js
Outdated
| const tests = [ | ||
| {title: "parses a simple <dfn>", | ||
| html: "<dfn id='foo'>Foo</dfn>", | ||
| dfns: [{}] |
There was a problem hiding this comment.
I thought I'd note that I had some initial difficulty reading this because, without looking at the rest of the code, this suggests that the extraction will produce one empty object. That is, it would be easier to grasp immediately if here and below, this were [baseDfn] (or [Object.assign({}, baseDfn)]). I realize that means duplicating code, but then code is written once, read many times...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to help with extending it to HTML (#333), SVG (#334) and refining the rules (#336)