WPT Cleanup #254

tommckee1 · 2021-01-28T15:26:10Z

As noted on the Jan 21 Web Perf Working Group call, we've noticed there are some parts of the spec that aren't being covered by Web Platform Tests. Right now, the tests are quite dissimilar and inconsistent which makes it more difficult to see what is and isn't covered.

This issue will track cleanup efforts to normalize and update the tests to a more tenable state. Specifically, we want to

Prefer promise_test to async_test
Prefer fetch_tests_from_window to hand-rolled message passing
Apply a consistent naming scheme to the files

The text was updated successfully, but these errors were encountered:

tommckee1 · 2021-01-28T15:48:20Z

Chrome tracking bug: crbug.com/1171767

We want to normalize and update our WPT tests for ResourceTiming. This change uses - 'promise_test' instead of 'async_test' - 'fetch_tests_from_window' instead of hand-rolled 'PostMessage' calls as well as some other small cleanups. Bug: 1171767 Change-Id: Id71c0eef898ffb4982785f01edd2a4df9b1bfbba GitHubIssue: w3c/resource-timing#254

We want to normalize and update our WPT tests for ResourceTiming. This change uses - 'promise_test' instead of 'async_test' - 'fetch_tests_from_window' instead of hand-rolled 'PostMessage' calls as well as some other small cleanups. Bug: 1171767 Change-Id: Id71c0eef898ffb4982785f01edd2a4df9b1bfbba GitHubIssue: w3c/resource-timing#254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2656419 Commit-Queue: Tom McKee <[email protected]> Reviewed-by: Yoav Weiss <[email protected]> Cr-Commit-Position: refs/heads/master@{#848574}

…tml, a=testonly Automatic update from web-platform-tests Updates for TAO-null-opaque-origin.sub.html We want to normalize and update our WPT tests for ResourceTiming. This change uses - 'promise_test' instead of 'async_test' - 'fetch_tests_from_window' instead of hand-rolled 'PostMessage' calls as well as some other small cleanups. Bug: 1171767 Change-Id: Id71c0eef898ffb4982785f01edd2a4df9b1bfbba GitHubIssue: w3c/resource-timing#254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2656419 Commit-Queue: Tom McKee <[email protected]> Reviewed-by: Yoav Weiss <[email protected]> Cr-Commit-Position: refs/heads/master@{#848574} -- wpt-commits: 1f6bc471fb537e733703cce3283fbb4d7f47547b wpt-pr: 27367

…tml, a=testonly Automatic update from web-platform-tests Updates for TAO-null-opaque-origin.sub.html We want to normalize and update our WPT tests for ResourceTiming. This change uses - 'promise_test' instead of 'async_test' - 'fetch_tests_from_window' instead of hand-rolled 'PostMessage' calls as well as some other small cleanups. Bug: 1171767 Change-Id: Id71c0eef898ffb4982785f01edd2a4df9b1bfbba GitHubIssue: w3c/resource-timing#254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2656419 Commit-Queue: Tom McKee <tommckeechromium.org> Reviewed-by: Yoav Weiss <yoavweisschromium.org> Cr-Commit-Position: refs/heads/master{#848574} -- wpt-commits: 1f6bc471fb537e733703cce3283fbb4d7f47547b wpt-pr: 27367 UltraBlame original commit: 3d2963e1bcd7f55e39c79fe902f37d673a08b121

…tml, a=testonly Automatic update from web-platform-tests Updates for TAO-null-opaque-origin.sub.html We want to normalize and update our WPT tests for ResourceTiming. This change uses - 'promise_test' instead of 'async_test' - 'fetch_tests_from_window' instead of hand-rolled 'PostMessage' calls as well as some other small cleanups. Bug: 1171767 Change-Id: Id71c0eef898ffb4982785f01edd2a4df9b1bfbba GitHubIssue: w3c/resource-timing#254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2656419 Commit-Queue: Tom McKee <[email protected]> Reviewed-by: Yoav Weiss <[email protected]> Cr-Commit-Position: refs/heads/master@{#848574} -- wpt-commits: 1f6bc471fb537e733703cce3283fbb4d7f47547b wpt-pr: 27367

In crbug.com/1171767 we're hoping to clean up and reorganize the Resource Timing WPT suite. Part of the cleanup is to adopt a consistent coding style. This change adds a markdown file with our style recommendations to the suite itself so future developers can reference it. Bug: 1171767 GithubIssue: w3c/resource-timing#254 Change-Id: I8d54fe74418808e82b524cbf5bcb5ef18c65a4df

In crbug.com/1171767 we're hoping to clean up and reorganize the Resource Timing WPT suite. Part of the cleanup is to adopt a consistent coding style. This change adds a markdown file with our style recommendations to the suite itself so future developers can reference it. Bug: 1171767 GithubIssue: w3c/resource-timing#254 Change-Id: I8d54fe74418808e82b524cbf5bcb5ef18c65a4df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2686434 Commit-Queue: Tom McKee <[email protected]> Reviewed-by: Yoav Weiss <[email protected]> Reviewed-by: Nicolás Peña Moreno <[email protected]> Cr-Commit-Position: refs/heads/master@{#853120}

…esource Timing, a=testonly Automatic update from web-platform-tests Adding a CodingConventions.md file for Resource Timing In crbug.com/1171767 we're hoping to clean up and reorganize the Resource Timing WPT suite. Part of the cleanup is to adopt a consistent coding style. This change adds a markdown file with our style recommendations to the suite itself so future developers can reference it. Bug: 1171767 GithubIssue: w3c/resource-timing#254 Change-Id: I8d54fe74418808e82b524cbf5bcb5ef18c65a4df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2686434 Commit-Queue: Tom McKee <[email protected]> Reviewed-by: Yoav Weiss <[email protected]> Reviewed-by: Nicolás Peña Moreno <[email protected]> Cr-Commit-Position: refs/heads/master@{#853120} -- wpt-commits: f6ace0de528eefd0d38b3e83a31512f227193ebb wpt-pr: 27579

This change rewrites a ResourceTiming WPT to use the updated style and file naming conventions in wpt/resource-timing/CodingConventions.md Bug: 1171767 Change-Id: I00d44affaaa702598c39bbdadf5f14f5a5392b93 GithubIssue: w3c/resource-timing#254

In ResourceTiming Web Platform Tests, we want to use assertion failures to indicate divergence from the spec but use exceptions to indicate issues with the test code. This change updates the style guide to call out this goal. Bug: 1171767 Change-Id: If9df3b05de75cbb516bc5c9f1ac0897abac0b4ab GithubIssue: w3c/resource-timing#254

This change rewrites a ResourceTiming WPT to use the updated style and file naming conventions in wpt/resource-timing/CodingConventions.md Bug: 1171767 Change-Id: I00d44affaaa702598c39bbdadf5f14f5a5392b93 GithubIssue: w3c/resource-timing#254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2698854 Reviewed-by: Yoav Weiss <[email protected]> Commit-Queue: Tom McKee <[email protected]> Cr-Commit-Position: refs/heads/master@{#855731}

In ResourceTiming Web Platform Tests, we want to use assertion failures to indicate divergence from the spec but use exceptions to indicate issues with the test code. This change updates the style guide to call out this goal. Bug: 1171767 Change-Id: If9df3b05de75cbb516bc5c9f1ac0897abac0b4ab GithubIssue: w3c/resource-timing#254

In ResourceTiming Web Platform Tests, we want to use assertion failures to indicate divergence from the spec but use exceptions to indicate issues with the test code. This change updates the style guide to call out this goal. Bug: 1171767 Change-Id: If9df3b05de75cbb516bc5c9f1ac0897abac0b4ab GithubIssue: w3c/resource-timing#254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2707184 Commit-Queue: Tom McKee <[email protected]> Reviewed-by: Yoav Weiss <[email protected]> Reviewed-by: Steve Kobes <[email protected]> Cr-Commit-Position: refs/heads/master@{#856285}

…m, a=testonly Automatic update from web-platform-tests ResourceTiming: Cleanup resource_hash.htm This change rewrites a ResourceTiming WPT to use the updated style and file naming conventions in wpt/resource-timing/CodingConventions.md Bug: 1171767 Change-Id: I00d44affaaa702598c39bbdadf5f14f5a5392b93 GithubIssue: w3c/resource-timing#254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2698854 Reviewed-by: Yoav Weiss <[email protected]> Commit-Queue: Tom McKee <[email protected]> Cr-Commit-Position: refs/heads/master@{#855731} -- wpt-commits: 29134beee3c9ca5f49f492ff2f90baa879496950 wpt-pr: 27662

In crbug.com/1171767 we're hoping to clean up and reorganize the Resource Timing WPT suite. Part of the cleanup is to adopt a consistent coding style. This change adds a markdown file with our style recommendations to the suite itself so future developers can reference it. Bug: 1171767 GithubIssue: w3c/resource-timing#254 Change-Id: I8d54fe74418808e82b524cbf5bcb5ef18c65a4df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2686434 Commit-Queue: Tom McKee <[email protected]> Reviewed-by: Yoav Weiss <[email protected]> Reviewed-by: Nicolás Peña Moreno <[email protected]> Cr-Commit-Position: refs/heads/master@{#853120} GitOrigin-RevId: 0f98e01a42c8b5c112b9e360076644d47b5c7aad

This change rewrites a ResourceTiming WPT to use the updated style and file naming conventions in wpt/resource-timing/CodingConventions.md Bug: 1171767 Change-Id: I00d44affaaa702598c39bbdadf5f14f5a5392b93 GithubIssue: w3c/resource-timing#254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2698854 Reviewed-by: Yoav Weiss <[email protected]> Commit-Queue: Tom McKee <[email protected]> Cr-Commit-Position: refs/heads/master@{#855731} GitOrigin-RevId: f1d3c28546d3aebdcc48a33b49805c10f19cf75a

In ResourceTiming Web Platform Tests, we want to use assertion failures to indicate divergence from the spec but use exceptions to indicate issues with the test code. This change updates the style guide to call out this goal. Bug: 1171767 Change-Id: If9df3b05de75cbb516bc5c9f1ac0897abac0b4ab GithubIssue: w3c/resource-timing#254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2707184 Commit-Queue: Tom McKee <[email protected]> Reviewed-by: Yoav Weiss <[email protected]> Reviewed-by: Steve Kobes <[email protected]> Cr-Commit-Position: refs/heads/master@{#856285} GitOrigin-RevId: a34c3f130f0bb052e25fb6b3c0dcff9df9e2cca1

The ResourceTiming spec describes the expected values for the attributes of PerformanceResourceTiming objects. The expected values follow a common pattern when the resource is fetched in particular ways like over HTTP or when the Timing-Allow-Origin header doesn't match. This change refactors a collection of assertions over one of these patterns into a helper function: assert_http_resource(). Bug: 1171767 Change-Id: I9e7aee031f65439fd36d58b480f0709d0a5ea5b5 GithubIssue: w3c/resource-timing#254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2732507 Commit-Queue: Tom McKee <[email protected]> Reviewed-by: Yoav Weiss <[email protected]> Cr-Commit-Position: refs/heads/master@{#861163} GitOrigin-RevId: 9611d37dc02d584de553eb3ffa643e6479b8405a

Tests in entry-attributes.html had a common setup preamble that could not be captured with WPT's setup() so was copy-pasted into each case. This change refactors the tests to rely on a helper that centralizes the common setup logic. Bug: 1171767 Change-Id: Id7164fddde4726888cb9c4f05958eac47398fdc9 GithubIssue: w3c/resource-timing#254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2733350 Commit-Queue: Tom McKee <[email protected]> Reviewed-by: Yoav Weiss <[email protected]> Cr-Commit-Position: refs/heads/master@{#861545} GitOrigin-RevId: 337a44a0946092d3de87fa06d32adb8f54ca1607

The spec requires that attributes of the PerformanceResourceTiming entries take on certain values when the underlying resource was fetched through an HTTP redirect. This change adds tests to validate - startTime - redirectStart - redirectEnd - fetchStart - domainLookupStart - domainLookupEnd - connectStart Bug: 1171767 Change-Id: Ia422c25aa9c6da55b318c7e21a1839359d104d82 GithubIssue: w3c/resource-timing#254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2736074 Commit-Queue: Tom McKee <[email protected]> Reviewed-by: Yoav Weiss <[email protected]> Cr-Commit-Position: refs/heads/master@{#861551} GitOrigin-RevId: af288bf3c15b2d3d01a0bef1672ade6146ffff55

Recent additions to entry-attributes.html make resource_timing_same_origin_redirect.html obsolete. This change removes the latter. Bug: 1171767 Change-Id: I946dd7b1e332e76d8b16a8912754ed3f029add20 GithubIssue: w3c/resource-timing#254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2735997 Commit-Queue: Tom McKee <[email protected]> Reviewed-by: Yoav Weiss <[email protected]> Cr-Commit-Position: refs/heads/master@{#861571} GitOrigin-RevId: c296927ebe370c92e7576b99382c8b0989852374

In our CodingConventions.md file, we want to encourage linking tests to the piece of the spec that they validate. This change adds <title> and <link> tags to cross-origin-status-codes.html. Bug: 1171767 Change-Id: I2a9b4d5df2488b80143f5acc924e1d10602ed62e GithubIssue: w3c/resource-timing#254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2740214 Commit-Queue: Tom McKee <[email protected]> Reviewed-by: Yoav Weiss <[email protected]> Cr-Commit-Position: refs/heads/master@{#861651} GitOrigin-RevId: 530443894b9812d3e5c4952f2d92d54cb68a1b72

As part of our WPT cleanup, we want to transition from using testharness.js' async_test towards promise_test. This change updates cross-origin-status-codes.html accordingly. Bug: 1171767 GithubIssue: w3c/resource-timing#254 Change-Id: If14f282171bc612a61774cc4b530284cc1cc4880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2740234 Commit-Queue: Tom McKee <[email protected]> Reviewed-by: Yoav Weiss <[email protected]> Cr-Commit-Position: refs/heads/master@{#861725} GitOrigin-RevId: 11bb6d6a06fc5f8210ebf4df8b0046441fd2f7e3

In order to make the distinction between setup code and asserting invariants, factor out the code that collects PerformanceResourceTiming entries and expose them through a Promise based API. Bug: 1171767 Change-Id: Id86e51e845ada462c726de9172f65699f07d6ff9 GithubIssue: w3c/resource-timing#254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2739405 Commit-Queue: Tom McKee <[email protected]> Reviewed-by: Yoav Weiss <[email protected]> Cr-Commit-Position: refs/heads/master@{#861756} GitOrigin-RevId: 779dd8683a10cdaf9fe418edbc4fac9ef72ed00b

To help with readability, we want to have a consistent style for function declaration within ResourceTiming's WPTs. This change amends the style guide to recommend which function declaration syntax we prefer. It also updates the tests we've already 'modernized' to conform to the updated style guide. Bug: 1171767 Change-Id: I5910d4de28ad911800d2bdd416bf4fbea7062ce1 GithubIssue: w3c/resource-timing#254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2764663 Reviewed-by: Yoav Weiss <[email protected]> Commit-Queue: Tom McKee <[email protected]> Cr-Commit-Position: refs/heads/master@{#863346} GitOrigin-RevId: ba041497d00807945057add393171e8707f4948e

…ipts The entry-attributes.html test introduced some helper functions to help with readability. To let other Resource Timing WPTs reference the helpers, this change moves them into some new helper .js files. Bug: 1171767 Change-Id: Iac76be6b143e360739e176a902bf10623714a113 GithubIssue: w3c/resource-timing#254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2766447 Reviewed-by: Yoav Weiss <[email protected]> Commit-Queue: Tom McKee <[email protected]> Cr-Commit-Position: refs/heads/master@{#864206} GitOrigin-RevId: a6b9748a5e4db903cfa0e0be2b97151a6797ec86

This change updates the redirects.sub.html WPT to follow the new style and structure we've been introducing in the linked bug. Bug: 1171767 Change-Id: I28bb746d01872b7ba4585750d86fc4d5a8d9af9b GithubIssue: w3c/resource-timing#254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2774478 Reviewed-by: Yoav Weiss <[email protected]> Commit-Queue: Tom McKee <[email protected]> Cr-Commit-Position: refs/heads/master@{#864435} GitOrigin-RevId: baa9e3c1b188ea693609dbbc11600fa5c9159f65

This change updates the resource_timing_cross_origin_redirect.html WPT to follow the new style we're introducing as part of the linked bug. Bug: 1171767 Change-Id: I1084e887f1436babd53aa2516054ace1461b4e89 GithubIssue: w3c/resource-timing#254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2774026 Reviewed-by: Yoav Weiss <[email protected]> Commit-Queue: Tom McKee <[email protected]> Cr-Commit-Position: refs/heads/master@{#865600} GitOrigin-RevId: dd9867db81837e129cd41d2ade9aaa21c00c95d7

…WPTs Older versions of the Resource Timing spec don't specify a strong enough ordering constraint between an element's "onload" and the PerformanceResourceTiming entry being added to the Performance Timeline. As such, our strategy of calling "performance.getEntriesByType()" after the "onload" event fires isn't guaranteed to return the expected entry. This CL modifies our approach to use, and block on, a PerformanceObserver being notified of entries being added to the timeline. This eliminates a class of flakiness we were seeing during manual testing. Bug: 1171767 Change-Id: Ifa4995683f5ef4ff6e53f9780f6d485e6cfb3d81 GithubIssue: w3c/resource-timing#254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2826597 Reviewed-by: Yoav Weiss <[email protected]> Commit-Queue: Tom McKee <[email protected]> Cr-Commit-Position: refs/heads/master@{#872849} GitOrigin-RevId: ddbed39d68cc78f5aa293c07290e95de0c193f2c

…html This change updates and renames the above file to match the new style and structure being introduced for the linked bug. In particular, this test was checking an odd corner case where a cross-origin redirect points to a same-origin resource but this was unapparent from the original name. Bug: 1171767 Change-Id: If3118a6a7333ec8520e36d8e8ae28bcbf0d20b9d GithubIssue: w3c/resource-timing#254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2774029 Commit-Queue: Tom McKee <[email protected]> Reviewed-by: Yoav Weiss <[email protected]> Cr-Commit-Position: refs/heads/master@{#876600} GitOrigin-RevId: 48be96f9d071ac2d80bef2d8292ff87b92232151

In order to reliably force loading a given resource, the helper functions in resource-loaders.js now add a "cache_bust" search parameter to URLs before loading them. This way, cache state won't leak into and interfere with running multiple ResourceTiming tests. Bug: 1171767 Change-Id: I9927963b0c467122c478cb6b137b7113487219d9 GithubIssue: w3c/resource-timing#254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2826596 Reviewed-by: Yoav Weiss <[email protected]> Reviewed-by: Nicolás Peña Moreno <[email protected]> Commit-Queue: Tom McKee <[email protected]> Cr-Commit-Position: refs/heads/master@{#877940} NOKEYCHECK=True GitOrigin-RevId: 677c649ca83de2ef8a5acb96520a04edcf398806

This change updates the name of some resources used for ResourceTiming WPTs. Bug: 1171767 Change-Id: I1fd1f97425058d02562e4477372e8afa1edd1424 GithubIssue: w3c/resource-timing#254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2780397 Commit-Queue: Yoav Weiss <[email protected]> Auto-Submit: Tom McKee <[email protected]> Reviewed-by: Yoav Weiss <[email protected]> Cr-Commit-Position: refs/heads/master@{#878879} NOKEYCHECK=True GitOrigin-RevId: 151c30d10af8568d16c8870701786d4b05602a1c

This CL updates the named test to a newer and more consistent style. Bug: 1171767 Change-Id: I5f588563c12ce797d177ce80e2f3591f2a04438c GithubIssue: w3c/resource-timing#254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2871371 Reviewed-by: Yoav Weiss <[email protected]> Commit-Queue: Tom McKee <[email protected]> Cr-Commit-Position: refs/heads/master@{#879319} NOKEYCHECK=True GitOrigin-RevId: 694ffd0663a2568ec336f3c824edfa28d429aa4e

This change updates the named test to use an updated style and some helper functions introduced as part of the linked bug. Bug: 1171767 Change-Id: I287498167b6bfa82dac894fe02c2a79326842005 GithubIssue: w3c/resource-timing#254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2872067 Reviewed-by: Yoav Weiss <[email protected]> Commit-Queue: Tom McKee <[email protected]> Cr-Commit-Position: refs/heads/master@{#879320} NOKEYCHECK=True GitOrigin-RevId: 5e0e591641d32a22d03e64b4e0ae40d269895529

This change rewrites (and renames) the above test to conform to the new style we're introducing to Resource Timing Web Platform Tests. See wpt/resource-timing/CodingingConventions.md for what the new style prescribes. Bug: 1171767 Change-Id: I84df93ab1165ab1e315dc406144791be3b1a5b28 GithubIssue: w3c/resource-timing#254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2881945 Reviewed-by: Yoav Weiss <[email protected]> Commit-Queue: Tom McKee <[email protected]> Cr-Commit-Position: refs/heads/master@{#883661} NOKEYCHECK=True GitOrigin-RevId: 3e386fe77a3dbcdf5921afa4830aa761c3eb439b

This change updates the named test to conform to the new style we're introducing to Resource Timing Web Platform Tests. With this change, we're also expanding the contexts under which the test will execute. Namely, this test will run under window, shared-worker and dedicated-worker contexts. Bug: 1171767 Change-Id: I7877cbb729299f37e253d9bf0c4902d76d963404 GithubIssue: w3c/resource-timing#254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2881221 Commit-Queue: Tom McKee <[email protected]> Reviewed-by: Yoav Weiss <[email protected]> Cr-Commit-Position: refs/heads/master@{#886879} NOKEYCHECK=True GitOrigin-RevId: 76153080e46287e7682c3c0532935378ebc18b70

This CL migrates the connection reuse WPTs to the new style. See wpt/resource-timing/CodingConventions.md for details. These tests exist to verify that the Resource Timing API yields correct PerformanceResourceTiming values when the underlying TCP connection is reused across multiple subresources. Bug: 1171767 Change-Id: I5acdb6bf8a5e71bb34c7d2236cdb9d0209d3d04d GithubIssue: w3c/resource-timing#254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2950880 Commit-Queue: Tom McKee <[email protected]> Reviewed-by: Yoav Weiss <[email protected]> Cr-Commit-Position: refs/heads/master@{#891368} NOKEYCHECK=True GitOrigin-RevId: 235b49717de3423fa6d9831a8165dc2b473902f0

This CL updates the cors-preflight.any.js test to conform to the new style/guidelines. In particular, some helpers have been renamed for clarity and we use a PerformanceObserver instead of calling performance.getEntriesByName(). Bug: 1171767 Change-Id: Ic6a0116e099a77a808bd9dc748f4a573ae349ad2 GitHubIssue: w3c/resource-timing#254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2951092 Reviewed-by: Yoav Weiss <[email protected]> Commit-Queue: Tom McKee <[email protected]> Cr-Commit-Position: refs/heads/master@{#891648} NOKEYCHECK=True GitOrigin-RevId: b1bb6f5a30bffff95f8b69c82a0361c147147122

Both TAO-null-opaque-origin.html and TAO-case-insensitive-null-opaque-origin.sub.html test the Resource Timing API when resources are fetched from an opaque origin context. This change updates those tests to conform to wpt/resource-timing/CodingConventions.md. Bug: 1171767 Change-Id: I3bfbaa4a714a4582a5c900aa345df118828e1e0e GithubIssue: w3c/resource-timing#254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3042198 Commit-Queue: Tom McKee <[email protected]> Reviewed-by: Yoav Weiss <[email protected]> Cr-Commit-Position: refs/heads/master@{#905292} NOKEYCHECK=True GitOrigin-RevId: bc323d6533122a07c92f3c3be44ad457b04d9f29

This CL updates WPTs checking the behaviour of the initiatorType field of PerformanceResourceTiming entries. For resources corresponding to elements present in the initial page response, the tests have been split into separate files grouped (roughly) by the element type. For resources corresponding to elements added to the page dynamically, coverage has also been added for fonts, scripts and XMLHttpRequests. Bug: 1171767 Change-Id: I547aab0db42d8f32bcbdfb310b16b4fddc103b18 GitHubIssue: w3c/resource-timing#254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2961075 Commit-Queue: Tom McKee <[email protected]> Reviewed-by: Yoav Weiss <[email protected]> Cr-Commit-Position: refs/heads/master@{#905732} NOKEYCHECK=True GitOrigin-RevId: 1d0cf3905ce74eae85ec01cffcb5a438bb042257

This change updates wpt/resource-timing/iframe-failed-commit.html to conform to the new style guidelines in wpt/resource-timing/CodingConventions.md. GithubIssue: w3c/resource-timing#254 Bug: 1171767 Change-Id: Ica54e4ea7fe9ae74bb1fa4274c803297577face8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3134283 Reviewed-by: Yoav Weiss <[email protected]> Commit-Queue: Tom McKee <[email protected]> Cr-Commit-Position: refs/heads/main@{#917277} NOKEYCHECK=True GitOrigin-RevId: fad2085a1ce70e25f7a805d5dee23e3c8456be06

This change updates the named test to conform to the new style described in wpt/resource-timing/CodingConventions.md. GithubIssue: w3c/resource-timing#254 Bug: 1171767 Change-Id: Iba63250828c33df477852aeddd1b1e1cf49f88c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3138593 Reviewed-by: Yoav Weiss <[email protected]> Commit-Queue: Tom McKee <[email protected]> Cr-Commit-Position: refs/heads/main@{#917665} NOKEYCHECK=True GitOrigin-RevId: 906fa723b8897f53d8e74ed6beab94074084dbad

This change updates the resource_reuse.sub.html and single-entry-per-resource.html Resource Timing WPTs. They covered the same case; when no network request is issued for a resource, there should be no associated PerformanceResourceTiming entry. The tests have been consolidated into cached-image-gets-single-entry.html and the style updated to conform to the guidelines in wpt/resource-timing/CodingConventions.md. GithubIssue: w3c/resource-timing#254 Bug: 1171767 Change-Id: Ibdc67dcedf70b96e317ace165eed4e5ec897e996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3138444 Reviewed-by: Yoav Weiss <[email protected]> Commit-Queue: Tom McKee <[email protected]> Cr-Commit-Position: refs/heads/main@{#918104} NOKEYCHECK=True GitOrigin-RevId: b9e62c069cad8399b8f9a72cc2d3f9a1d96d3e6d

This change updates the named tests to more closely conform to the new style guide in wpt/resource-timing/CodingConventions.md. There should be no behavioural changes with this CL. GithubIssue: w3c/resource-timing#254 Bug: 1171767 Change-Id: I69b85941d4e65351fde398c24e6c34b40f51adae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3141532 Auto-Submit: Tom McKee <[email protected]> Reviewed-by: Yoav Weiss <[email protected]> Commit-Queue: Yoav Weiss <[email protected]> Cr-Commit-Position: refs/heads/main@{#925777} NOKEYCHECK=True GitOrigin-RevId: 37f97a4caccb90302af8183a65dc85068e6559c1

chromium-wpt-export-bot mentioned this issue Jan 28, 2021

Updates for TAO-null-opaque-origin.sub.html web-platform-tests/wpt#27367

Merged

chromium-wpt-export-bot mentioned this issue Feb 10, 2021

Adding a CodingConventions.md file for Resource Timing web-platform-tests/wpt#27579

Merged

chromium-wpt-export-bot mentioned this issue Feb 17, 2021

ResourceTiming: Cleanup resource_hash.htm web-platform-tests/wpt#27662

Merged

chromium-wpt-export-bot mentioned this issue Feb 19, 2021

Update ResourceTiming style guide to explain asserts vs. errors web-platform-tests/wpt#27707

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WPT Cleanup #254

WPT Cleanup #254

tommckee1 commented Jan 28, 2021

tommckee1 commented Jan 28, 2021

WPT Cleanup #254

WPT Cleanup #254

Comments

tommckee1 commented Jan 28, 2021

tommckee1 commented Jan 28, 2021