-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add interim response times #366
Conversation
Seems reasonable once the Fetch bits land. |
index.html
Outdated
{{PerformanceResourceTiming/firstInterimResponseStart}}, | ||
{{PerformanceResourceTiming/responseStart}}, | ||
{{PerformanceResourceTiming/responseHeadersEnd}}, | ||
{{PerformanceResourceTiming/responseBodyStart}}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making sure that the new timings require CORS. This is an essential requirement mentioned in the Chrome Security & Privacy intent review in order to avoid cross-origin leaks.
Why only the first 103? What about a 109? |
Also, should we call this "interim" or "informational"? Is there any precedent in the web platform? |
Because it's the only informational/interim header processed by the web platform. |
That was the proposal on the issue and it seemed ok at the time. I don't really mind renaming it to informational. @tunetheweb @yoavweiss any objections? |
Well, we handle all of them. We have some special code for 101 and 103, but it's not like we bail out when we see a 102. (Also the current Fetch PR is not restricted to a 103.) |
@LPardue from the IETF HTTP WG had some strong opinions on "informational":
|
Right, RFC9110 does use the term "interim". @annevk does that satisfy "precedent in the web platform"? |
It certainly does, thanks for digging that up. |
By handle I mean actually do something meaningful with them. Perhaps this could be named |
@LPardue had some strong views on that too :-)
|
Right, but that means we should measure the first 1xx (if any), not the first 103. Which I tend to agree with. |
"Early" here is for "Early hints" which is the term used in RFC8297. I think it's a misunderstanding of the context of |
OK with me. So in conclusion I'll change the description & spec & implementation to also include 100, and we'll keep the |
Add 3 response times: - firstInterimResponseStart: the first 103 - responseHeadersEnd: All headers have been received - responseBodyStart: The body started streaming Closes #345 Depends on whatwg/fetch#1483
Done. Also removed the two unimplemented timings. |
It seems fine to expose less, but #345 (comment) did have use cases for the others so that should still be tracked in some way I suppose? Does this change also impact the request over at WebKit/standards-positions#109? |
There is a use case for the others but decided to implement them gradually. Currently only
The standard position should consider that |
Amending implementation based on spec change as per review See discussion: w3c/resource-timing#366 Refactored HTTP1 & HTTP2 tests to be flexible as to whether to send 100 response. Bug: 1402089
Amending implementation based on spec change as per review See discussion: w3c/resource-timing#366 Refactored HTTP1 & HTTP2 tests to be flexible as to whether to send 100 response. Bug: 1402089 Change-Id: If47bd5bf25425f9e5a012cd46be99bdaa1ec6969
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Amending implementation based on spec change as per review See discussion: w3c/resource-timing#366 Refactored HTTP1 & HTTP2 tests to be flexible as to whether to send 100 response. Bug: 1402089 Change-Id: If47bd5bf25425f9e5a012cd46be99bdaa1ec6969 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4507473 Commit-Queue: Noam Rosenthal <[email protected]> Reviewed-by: Yoav Weiss <[email protected]> Cr-Commit-Position: refs/heads/main@{#1141426}
Amending implementation based on spec change as per review See discussion: w3c/resource-timing#366 Refactored HTTP1 & HTTP2 tests to be flexible as to whether to send 100 response. Bug: 1402089 Change-Id: If47bd5bf25425f9e5a012cd46be99bdaa1ec6969 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4507473 Commit-Queue: Noam Rosenthal <[email protected]> Reviewed-by: Yoav Weiss <[email protected]> Cr-Commit-Position: refs/heads/main@{#1141426}
Amending implementation based on spec change as per review See discussion: w3c/resource-timing#366 Refactored HTTP1 & HTTP2 tests to be flexible as to whether to send 100 response. Bug: 1402089 Change-Id: If47bd5bf25425f9e5a012cd46be99bdaa1ec6969 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4507473 Commit-Queue: Noam Rosenthal <[email protected]> Reviewed-by: Yoav Weiss <[email protected]> Cr-Commit-Position: refs/heads/main@{#1141426}
…t should include 100 responses, a=testonly Automatic update from web-platform-tests ResourceTiming: firstInterimResponseStart should include 100 responses Amending implementation based on spec change as per review See discussion: w3c/resource-timing#366 Refactored HTTP1 & HTTP2 tests to be flexible as to whether to send 100 response. Bug: 1402089 Change-Id: If47bd5bf25425f9e5a012cd46be99bdaa1ec6969 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4507473 Commit-Queue: Noam Rosenthal <[email protected]> Reviewed-by: Yoav Weiss <[email protected]> Cr-Commit-Position: refs/heads/main@{#1141426} -- wpt-commits: fd5c04fb75f07887491c0c47999a5e95d40b190c wpt-pr: 39881
…t should include 100 responses, a=testonly Automatic update from web-platform-tests ResourceTiming: firstInterimResponseStart should include 100 responses Amending implementation based on spec change as per review See discussion: w3c/resource-timing#366 Refactored HTTP1 & HTTP2 tests to be flexible as to whether to send 100 response. Bug: 1402089 Change-Id: If47bd5bf25425f9e5a012cd46be99bdaa1ec6969 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4507473 Commit-Queue: Noam Rosenthal <[email protected]> Reviewed-by: Yoav Weiss <[email protected]> Cr-Commit-Position: refs/heads/main@{#1141426} -- wpt-commits: fd5c04fb75f07887491c0c47999a5e95d40b190c wpt-pr: 39881
Add
firstInterimResponseStart
: the first response with an informational (1XX) status.Bug: #345
Depends on whatwg/fetch#1483
For now not adding headers-end and body-start as they're not planned to be implemented.
Preview | Diff