Remove WakeLockEvent and WakeLockEventInit. #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakuco
requested review from
reillyeon,
kenchris and
marcoscaceres
and removed request for
reillyeon
kenchris
approved these changes
Oct 17, 2019
|
Testing this in WPT depends on web-platform-tests/wpt#5671 for permissions support in testdriver.js. I've added a test to Blink in the meantime in https://chromium-review.googlesource.com/c/chromium/src/+/1865347 |
marcoscaceres
approved these changes
Oct 18, 2019
Per https://w3ctag.github.io/design-principles/#state-and-subclassing, we do not really need a custom event class here. `WakeLockEvent` has a single attribute, `lock`, that points to the event target. That's exactly what `Event.target` also does, so we can just create a simple `Event` instance and let the "fire an event" DOM algorithm set `target` for us to achieve the same thing. In fact, it already does, so before this commit we had ev.lock === ev.target Fixes w3c#238.
rakuco
force-pushed
the
remove-WakeLockEvent
branch
from
6f94131
to
826e89f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per https://w3ctag.github.io/design-principles/#state-and-subclassing, we do
not really need a custom event class here.
WakeLockEventhas a single attribute,lock, that points to the eventtarget. That's exactly what
Event.targetalso does, so we can just createa simple
Eventinstance and let the "fire an event" DOM algorithm settargetfor us to achieve the same thing. In fact, it already does, sobefore this commit we had
Fixes #238.
The following tasks have been completed:
Implementation commitment:
Preview | Diff