editorial: Adapt to Page Visibility spec integration into HTML #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Page Visibility spec has been merged into the HTML spec itself. This merge got rid of some terms and changed a few others, so adjust things accordingly here: * Instead of calling the "determine the visibility state", access a Document's "visibility state" directly. * The "external now hidden algorithm" no longer exists; now there are "page visibility change steps" called with a Document and a visibility state. (The HTML spec itself says specs should have the HTML spec call these steps so that the order of calls is defined in the spec, which we might need to do later). Fixes w3c#331
marcoscaceres
approved these changes
Dec 7, 2021
|
This looks great! Thanks @rakuco. |
|
CC'ing @noamr... as another spec that might need further integration into HTML down the road. Maybe we should have a meta issue being linked to from the HTML spec? |
2 tasks
|
Filed whatwg/html#7396 |
Good idea, thanks for opening the meta-issue. |
rakuco
added a commit
to rakuco/wake-lock
that referenced
this pull request
Dec 7, 2021
Follow-up to w3c#332. The Page Visibility spec was merged into the HTML spec itself, so we do not need to explicitly reference it from `xref` anymore.
rakuco
added a commit
that referenced
this pull request
Dec 7, 2021
Follow-up to #332. The Page Visibility spec was merged into the HTML spec itself, so we do not need to explicitly reference it from `xref` anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Page Visibility spec has been merged into the HTML spec itself. This
merge got rid of some terms and changed a few others, so adjust things
accordingly here:
Document's "visibility state" directly.
visibility change steps" called with a Document and a visibility state.
(The HTML spec itself says specs should have the HTML spec call these
steps so that the order of calls is defined in the spec, which we might
need to do later).
Fixes #331
Preview | Diff