Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the permission request algorithm normative #401

Merged
merged 1 commit into from
Dec 6, 2019
Merged

Make the permission request algorithm normative #401

merged 1 commit into from
Dec 6, 2019

Conversation

anssiko
Copy link
Member

@anssiko anssiko commented Dec 3, 2019 •
edited by pr-preview bot
Loading

Note in SOTD [PERMISSIONS-REQUEST] is "at-risk".

Related: #397

Preview | Diff

@anssiko
Make the permission request algorithm normative
7f05923 
Note in SOTD [PERMISSIONS-REQUEST] is "at-risk".
@anssiko anssiko mentioned this pull request Dec 3, 2019
Open
@anssiko anssiko requested a review from xfq December 5, 2019 13:19
@anssiko
Copy link
Member Author

anssiko commented Dec 5, 2019

I think @reillyeon might be OoO. Based on his feedback in #397, I think he'd be fine with this PR.

PTAL @xfq

@anssiko anssiko mentioned this pull request Dec 5, 2019
Closed
xfq
xfq approved these changes Dec 6, 2019
View reviewed changes
Copy link
Member

@xfq xfq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xfq xfq merged commit 1ca439c into master Dec 6, 2019
@xfq
Copy link
Member

xfq commented Dec 6, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xfq xfq xfq approved these changes

@reillyeon reillyeon Awaiting requested review from reillyeon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anssiko @xfq