Automation: Remove "virtual sensor type" from virtual sensor metadata #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This practically untangles the concepts in the Automation section from the rest of the specification, which helps the Device Orientation API specification adopt it as discussed in w3c/deviceorientation#122. Now a sensor type itself can optionally define a "virtual sensor type", a string. It is the same string used to refer to a given virtual sensor type in the WebDriver extension commands. In practice, this means that: - The per-top-level traversable virtual sensor mapping has become a mapping of virtual sensor types to virtual sensor. - The per-type virtual sensor metadata mapping has become a mapping of virtual sensor types to virtual sensor metadata. - Sensor types that define a virtual sensor type attempt to retrieve a virtual sensor from the virtual sensor mapping using this string as key. There are no user-visible changes or changes to the WebDriver extension commands, it is only the concepts and data structures used internally in the specification that have changed a little. Derived specifications will need to be adjusted accordingly once this pull request is merged.
This was referenced Nov 21, 2023
|
(FWIW I think this change makes sense regardless of w3c/deviceorientation#124) |
reillyeon
approved these changes
Nov 21, 2023
rakuco
deleted the
automation/untangle-sensor-type-and-virtual-sensors
branch
rakuco
added a commit
to rakuco/accelerometer
that referenced
this pull request
Nov 22, 2023
The PR above removed the "virtual sensor type" item from the "virtual sensor metadata" struct and turned it into a string that is referenced from the automation bits as well as (optionally) defined by a sensor type. Adapt to it here by removing mentions of `[=virtual sensor metadata/virtual sensor type=]` from the spec and adding virtual sensor types to each sensor type defined here.
rakuco
added a commit
to rakuco/ambient-light
that referenced
this pull request
Nov 22, 2023
The PR above removed the "virtual sensor type" item from the "virtual sensor metadata" struct and turned it into a string that is referenced from the automation bits as well as (optionally) defined by a sensor type. Adapt to it here by removing mentions of `[=virtual sensor metadata/virtual sensor type=]` from the spec and adding virtual sensor types to each sensor type defined here.
rakuco
added a commit
to rakuco/accelerometer
that referenced
this pull request
Nov 22, 2023
The PR above removed the "virtual sensor type" item from the "virtual sensor metadata" struct and turned it into a string that is referenced from the automation bits as well as (optionally) defined by a sensor type. Adapt to it here by removing mentions of `[=virtual sensor metadata/virtual sensor type=]` from the spec and adding virtual sensor types to each sensor type defined here.
rakuco
added a commit
to rakuco/geolocation-sensor
that referenced
this pull request
Nov 22, 2023
w3c/sensors#475 removed the "virtual sensor type" item from the "virtual sensor metadata" struct and turned it into a string that is referenced from the automation bits as well as (optionally) defined by a sensor type. Adapt to it here by removing mentions of `[=virtual sensor metadata/virtual sensor type=]` from the spec and adding virtual sensor types to each sensor type defined here.
This was referenced Nov 22, 2023
rakuco
added a commit
to rakuco/gyroscope
that referenced
this pull request
Nov 22, 2023
w3c/sensors#475 removed the "virtual sensor type" item from the "virtual sensor metadata" struct and turned it into a string that is referenced from the automation bits as well as (optionally) defined by a sensor type. Adapt to it here by removing mentions of `[=virtual sensor metadata/virtual sensor type=]` from the spec and adding virtual sensor types to each sensor type defined here.
rakuco
added a commit
to rakuco/magnetometer
that referenced
this pull request
Nov 22, 2023
w3c/sensors#475 removed the "virtual sensor type" item from the "virtual sensor metadata" struct and turned it into a string that is referenced from the automation bits as well as (optionally) defined by a sensor type. Adapt to it here by removing mentions of `[=virtual sensor metadata/virtual sensor type=]` from the spec and adding virtual sensor types to each sensor type defined here.
rakuco
added a commit
to w3c/orientation-sensor
that referenced
this pull request
Nov 22, 2023
w3c/sensors#475 removed the "virtual sensor type" item from the "virtual sensor metadata" struct and turned it into a string that is referenced from the automation bits as well as (optionally) defined by a sensor type. Adapt to it here by removing mentions of `[=virtual sensor metadata/virtual sensor type=]` from the spec and adding virtual sensor types to each sensor type defined here.
This was referenced Nov 22, 2023
rakuco
added a commit
to rakuco/proximity
that referenced
this pull request
Nov 22, 2023
w3c/sensors#475 removed the "virtual sensor type" item from the "virtual sensor metadata" struct and turned it into a string that is referenced from the automation bits as well as (optionally) defined by a sensor type. Adapt to it here by removing mentions of `[=virtual sensor metadata/virtual sensor type=]` from the spec and adding virtual sensor types to each sensor type defined here.
reillyeon
pushed a commit
to w3c/ambient-light
that referenced
this pull request
Nov 27, 2023
The PR above removed the "virtual sensor type" item from the "virtual sensor metadata" struct and turned it into a string that is referenced from the automation bits as well as (optionally) defined by a sensor type. Adapt to it here by removing mentions of `[=virtual sensor metadata/virtual sensor type=]` from the spec and adding virtual sensor types to each sensor type defined here.
github-actions bot
added a commit
to w3c/ambient-light
that referenced
this pull request
Nov 27, 2023
SHA: 8bb663d Reason: push, by reillyeon Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
reillyeon
pushed a commit
to w3c/geolocation-sensor
that referenced
this pull request
Nov 27, 2023
w3c/sensors#475 removed the "virtual sensor type" item from the "virtual sensor metadata" struct and turned it into a string that is referenced from the automation bits as well as (optionally) defined by a sensor type. Adapt to it here by removing mentions of `[=virtual sensor metadata/virtual sensor type=]` from the spec and adding virtual sensor types to each sensor type defined here.
github-actions bot
added a commit
to w3c/geolocation-sensor
that referenced
this pull request
Nov 27, 2023
SHA: 361f1e2 Reason: push, by reillyeon Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
reillyeon
pushed a commit
to w3c/magnetometer
that referenced
this pull request
Nov 27, 2023
w3c/sensors#475 removed the "virtual sensor type" item from the "virtual sensor metadata" struct and turned it into a string that is referenced from the automation bits as well as (optionally) defined by a sensor type. Adapt to it here by removing mentions of `[=virtual sensor metadata/virtual sensor type=]` from the spec and adding virtual sensor types to each sensor type defined here.
github-actions bot
added a commit
to w3c/magnetometer
that referenced
this pull request
Nov 27, 2023
SHA: 551cb02 Reason: push, by reillyeon Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
reillyeon
pushed a commit
to w3c/proximity
that referenced
this pull request
Nov 27, 2023
w3c/sensors#475 removed the "virtual sensor type" item from the "virtual sensor metadata" struct and turned it into a string that is referenced from the automation bits as well as (optionally) defined by a sensor type. Adapt to it here by removing mentions of `[=virtual sensor metadata/virtual sensor type=]` from the spec and adding virtual sensor types to each sensor type defined here.
github-actions bot
added a commit
to w3c/proximity
that referenced
this pull request
Nov 27, 2023
SHA: d9ead97 Reason: push, by reillyeon Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
rakuco
added a commit
to w3c/orientation-sensor
that referenced
this pull request
Nov 28, 2023
w3c/sensors#475 removed the "virtual sensor type" item from the "virtual sensor metadata" struct and turned it into a string that is referenced from the automation bits as well as (optionally) defined by a sensor type. Adapt to it here by removing mentions of `[=virtual sensor metadata/virtual sensor type=]` from the spec and adding virtual sensor types to each sensor type defined here.
github-actions bot
added a commit
to w3c/orientation-sensor
that referenced
this pull request
Nov 28, 2023
SHA: 51ca1fb Reason: push, by rakuco Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
rakuco
added a commit
to rakuco/accelerometer
that referenced
this pull request
Nov 28, 2023
The PR above removed the "virtual sensor type" item from the "virtual sensor metadata" struct and turned it into a string that is referenced from the automation bits as well as (optionally) defined by a sensor type. Adapt to it here by removing mentions of `[=virtual sensor metadata/virtual sensor type=]` from the spec and adding virtual sensor types to each sensor type defined here.
reillyeon
pushed a commit
to w3c/accelerometer
that referenced
this pull request
Nov 28, 2023
The PR above removed the "virtual sensor type" item from the "virtual sensor metadata" struct and turned it into a string that is referenced from the automation bits as well as (optionally) defined by a sensor type. Adapt to it here by removing mentions of `[=virtual sensor metadata/virtual sensor type=]` from the spec and adding virtual sensor types to each sensor type defined here.
github-actions bot
added a commit
to w3c/accelerometer
that referenced
this pull request
Nov 28, 2023
SHA: 7fd366f Reason: push, by reillyeon Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
rakuco
added a commit
to rakuco/gyroscope
that referenced
this pull request
Dec 5, 2023
w3c/sensors#475 removed the "virtual sensor type" item from the "virtual sensor metadata" struct and turned it into a string that is referenced from the automation bits as well as (optionally) defined by a sensor type. Adapt to it here by removing mentions of `[=virtual sensor metadata/virtual sensor type=]` from the spec and adding virtual sensor types to each sensor type defined here. Fixes w3c#58.
anssiko
added a commit
to w3c/gyroscope
that referenced
this pull request
Dec 7, 2023
Adapt to virtual sensor changes in w3c/sensors#475
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This practically untangles the concepts in the Automation section from the
rest of the specification, which helps the Device Orientation API
specification adopt it as discussed in w3c/deviceorientation#122.
Now a sensor type itself can optionally define a "virtual sensor type",
a string. It is the same string used to refer to a given virtual sensor type
in the WebDriver extension commands.
In practice, this means that:
of virtual sensor types to virtual sensor.
virtual sensor types to virtual sensor metadata.
virtual sensor from the virtual sensor mapping using this string as key.
There are no user-visible changes or changes to the WebDriver extension
commands, it is only the concepts and data structures used internally in the
specification that have changed a little.
Derived specifications will need to be adjusted accordingly once this pull
request is merged.
Preview | Diff