Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from quoted triples to triple terms #149

Merged
merged 5 commits into from
Aug 29, 2024
Merged

Conversation

rubensworks
Copy link
Member

@rubensworks rubensworks commented Aug 12, 2024

Following the changes in w3c/rdf-concepts@6b7ea76, this PR uses triple terms instead of quoted triples.

For the TRIPLE function shorthand, the same syntax was used as in Turtle: <<( ?s ?p ?o )>>

This PR does not yet update the grammar, as I believe this was auto-generated before.
@afs I believe you had such a generator? Could you look into running it for these changes? (also for SPARQL Update I guess)
I guess we can do this in a separate PR from this one.


Preview | Diff

@afs
Copy link
Contributor

afs commented Aug 12, 2024

I have a updated grammar in-progress. It includes the current reifier token, multiple reified on stated triples and the multiple annotations work that is now part of Turtle.

It's written - there a few tasks to complete:

  • The triples output needs checking - this shows whether the grammar is right or not
  • The naming needs to be checked/aligned to the Turtle grammar (QuotedTriple->TripleTerm is done)

Copy link
Contributor

@hartig hartig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member

@gkellogg gkellogg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with this, but we should probably use "reifying triples" in examples, rather than "triple terms".

@TallTed
Copy link
Member

TallTed commented Aug 15, 2024

[@gkellogg] Fine with this, but we should probably use "reffing triples" in examples, rather than "triple terms".

I'm sure "reffing triples" is a typo.

I think you meant "reified triples" (which are the objects of "reifying triples"), but maybe you meant "reifying triples" (which have rdf:reifies as predicate).

spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
rubensworks and others added 3 commits August 22, 2024 08:24
Co-authored-by: Olaf Hartig <[email protected]>
Co-authored-by: Olaf Hartig <[email protected]>
Co-authored-by: Olaf Hartig <[email protected]>
@rubensworks rubensworks merged commit d879cf4 into main Aug 29, 2024
2 checks passed
@rubensworks rubensworks deleted the feature/triple-terms branch August 29, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:substantive Issue or proposed change in the spec that changes its normative content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants