Skip to content

Commit

Permalink
Reviewer feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
dirkschulze committed Nov 26, 2018
1 parent 122adf7 commit cbe82bd
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 7 deletions.
3 changes: 2 additions & 1 deletion master/definitions.xml
Original file line number Diff line number Diff line change
Expand Up @@ -1219,7 +1219,8 @@
<interface name='CanvasDrawPath' href='https://html.spec.whatwg.org/multipage/canvas.html#canvasdrawpath' />

<!-- ... terms .......................................................... -->
<term name='Animation type' href='https://www.w3.org/TR/web-animations-1/#animating-properties'/>
<term name='Animation type' href='https://www.w3.org/TR/web-animations-1/#animation-type'/>
<term name='not additive' href='https://drafts.csswg.org/css-values-4/#not-additive'/>
<term name='event type' href='https://dom.spec.whatwg.org/#ref-for-dom-event-type'/>
<term name='event handler content attribute' href='https://html.spec.whatwg.org/multipage/webappapis.html#event-handler-content-attributes'/>
<term name='compound selector' href='http://dev.w3.org/csswg/selectors4/#compound'/>
Expand Down
15 changes: 9 additions & 6 deletions master/painting.html
Original file line number Diff line number Diff line change
Expand Up @@ -1224,12 +1224,15 @@ <h3 id="StrokeDashing">Dashing strokes: the <span class="property">'stroke-dasha
<a>'stroke-dasharray'</a>: each dash and gap length is interpreted relative
to the author's path length as specified by <a>'path/pathLength'</a>.</p>

<p id="interpolationDashPattern"><a>'stroke-dasharray'</a> must use discrete
interpolation if <var>start</var> or <var>end</var> value compute to <span class="prop-value">none</span>
or are invalid.
Otherwise, repeat both dash patterns of <var>start</var> and <var>end</var> value list until the length
of elements in both value lists match. Each item is then combined by computed value.
The interpolation is <a href="https://svgwg.org/specs/animations/#AdditionAttributes">non-additive</a>.</p>
<p id="interpolationDashPattern"><a>'stroke-dasharray'</a> values are <a>not additive</a>. For interpolation,
<a>'stroke-dasharray'</a> values are combined as follows:</p>
<dl class="switch">
<dt>If either <var>start</var> or <var>end</var> compute to <span class="prop-value">none</span> or are invalid</dt>
<dd><var>start</var> or <var>end</var> are combined using the discrete animation type.</dd>
<dt>Otherwise</dt>
<dd>repeat both dash patterns of <var>start</var> and <var>end</var> value list until the length of elements in
both value lists match. Each item is then combined by computed value.</dd>
</dl>

<div class="example">
The two <a>'stroke-dasharray'</a> value lists in the following example have different number
Expand Down

0 comments on commit cbe82bd

Please sign in to comment.