Painting: numeric stroke-width, stroke-dashoffset #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SVG 1.1 allowed stroke-width and stroke-dashoffset lengths to be specified without units. https://www.w3.org/TR/SVG11/types.html#DataTypeLength SVG 2 needs to do the same, for web compatibility. Discussed in w3c#534
dirkschulze
requested changes
Nov 17, 2018
|
@ericwilligers #586 landed which covers the changes in this PR. I am closing this PR now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SVG 1.1 allowed stroke-width and stroke-dashoffset lengths
to be specified without units.
https://www.w3.org/TR/SVG11/types.html#DataTypeLength
SVG 2 needs to do the same, for web compatibility.
Discussed in #534