Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content Magnification Fixes [resolves aria-practices issue 2606] #204

Merged
merged 4 commits into from
Mar 9, 2023

Conversation

aleenaloves
Copy link
Collaborator

Fix for this issue

Changes:

  • Converting px unit media queries to em units based on the custom media selectors in the theme css file.
  • On further magnification, also changing the title of the pattern to fall below the image so it does not overflow the div.

@netlify
Copy link

netlify bot commented Mar 6, 2023

Deploy Preview for aria-practices ready!

Name Link
🔨 Latest commit a37ac09
🔍 Latest deploy log https://app.netlify.com/sites/aria-practices/deploys/6406286ad33ca100085e6924
😎 Deploy Preview https://deploy-preview-204--aria-practices.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@alflennik alflennik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Aleena, I confirmed that both w3c/aria-practices#2601 and w3c/aria-practices#2606 are fixed, and I appreciated the way you updated the breakpoints across the entire site instead of just the ones that were highlighted in the issues. Nice.

@mcking65 mcking65 changed the title [Issue 2606] - Content Magnification Fixes Content Magnification Fixes [resolves aria-practices issue 2606] Mar 7, 2023
@mcking65
Copy link
Contributor

mcking65 commented Mar 7, 2023

Added to today's agenda

@aleenaloves aleenaloves merged commit f42fd7a into w3c:main Mar 9, 2023
@aleenaloves aleenaloves deleted the issue-2606-magnification-fixes branch March 9, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants