Feature: Search for patterns, toggle grid/list view #329
Conversation
✅ Deploy Preview for aria-practices ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -105,63 +195,104 @@ ul.tiles { | |||
| } | |||
| } | |||
|
|
|||
| li.tile { | |||
There was a problem hiding this comment.
Seems the Practices page uses the tile classname so this change (and other related css rules) would also affect there
This change:
vs what's on production:
There was a problem hiding this comment.
Wow clutch catch thank you! I obviously didn't realize that it was being used elsewhere. Have been in module land for too long.
My original intent for renaming was just to get away from potentially misleading classes (ie avoid a situation in which a ul class="list" has li class="tile"). I handled the regression with this commit (3e794ee) but if we wanted to take it a step further I would advocate for getting rid of both the "tile" and "pattern" classes in favor of some more generic name for both so that all styling can just be derived from the class of the parent ul across both pages. This isn't essential though.
|
Updates based on @isaacdurazo 's mockups from the feedback in the APG task force meeting:
|
There was a problem hiding this comment.
@stalgiag well done on this work!
w3c/aria-practices#3043 has now been approved and merged, so I went ahead and updated the aria-practices .gitmodule commit being pointed to, to resolve the conflict that was present before any Infrastructure clashes happen with new PRs being submitted on w3c/aria-practices
see aria-practices/#2534 for more information.
These are the build repo updates to accompany aria-practices/#3043.
From that PR: