Create update-pr.yml #2220
Closed
Create update-pr.yml #2220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add pull request preview
|
@kfranqueiro @iadawn is this PR still valid/needed? |
|
Probably not. @kfranqueiro can you confirm? |
|
This prefixes the PR body text with a link to the guidelines page using githack.com. Technically this isn't redundant with the Eleventy build (which doesn't output guidelines). However, I'm still not sure if we'd want it:
|
kfranqueiro
added a commit
that referenced
this pull request
Nov 15, 2024
This effectively replaces what the pr-preview bot currently does (and what #2220 sought to do within the repo). The problem with the pr-preview bot is its previews don't fully work (e.g. as seen in #4123). ## Changes - Remove `.pr-preview.json` to stop pr-preview bot from running - Add logic to `eleventy.config.ts` to copy `guidelines` folder assets and run through spec-generator (the same thing we use for GH Pages builds; also the same thing used by the pr-preview bot, IIUC) when running a standard build through netlify - Conditionally add guidelines list item to top-level `index.html` (which is only used for local dev and PR builds) - Tangentially, rename our github-pages push workflow to be more distinguishable in the Actions tab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview Changes
Add pull request preview