-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support marking obsolete techniques and restore removed ones #3975
Conversation
✅ Deploy Preview for wcag2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Could we make it stand out a bit more? Something along the lines of (but better looking) the note on the W3C's HTML 5 spec, for example. I'm not suggesting it be another fixed position box, it's more the fact that it stands out visually. |
I would like to make it stand out a bit more. Will have a play. |
kfranqueiro marked as non substantive for IPR from ash-nazg. |
6fdd695
to
781efe5
Compare
781efe5
to
2757a67
Compare
Kevin sent me his changes (which are great, I was unaware of the CSS variables available in the W3C site's CSS) and I've integrated them with a couple of changes:
|
Is there a reason not to use the WAI site component for Document Notes, e.g., Deprecated? We can create one for Obsolete. We can also update the component visual design and other if we deem that best. The component currently adds the note type to the |
(Oops, missed the link to 'deprecated' - some of the below still applies) Was thinking about the approach that I took before seeing the Archive component. This what was I had in mind when creating the Obsolete approach:
The Archived component does some of one, none of two and some of three. The obsolete box is that bit more salient: whole block colour, stronger block heading style. Arguable whether red or yellow is more visually salient, that may be much more of a preference. One thing I did play about with was including an icon to make it even stronger as a warning. I included a left hand border as something to try to hint at there being something different about this page. Bars like this are are a relatively common way to link together content (for example GDS error message component) although I would struggle to find a pattern where it is used full page. Finally, Obsolete pages includes content in the Broadly speaking I think there is a need for a component that is stronger than archived. Archived content may still have some interest within it, Obsolete content should not be used. These are slightly different points. |
I am fine with going with the EO deprecated style for the obsolete, but also think Kevin's comments about a visual distinction have merit. Either is an improvement on current, and either would be satisfactory IMO. |
Just my first impression opinion, this is all moving in the right direction and an improvement. Thank you Shawn and Keven and EO.
+1 to deprecated component, -1 to archived component. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are unilaterally an improvement..
- Can we find a disclaimer on Adobe.com wrt Flash being unsupported to link to? (And to something similar for Silverlight?)
- For the technique using summary attribute on tables, please mention the version or year the attribute was dropped from HTML.
@kfranqueiro what is the plan for 2.1 and 4.1.1 Techniques?. I am of the opinion they should also be flagged as Obsolete.
|
@bruce-usab I marked them as This property has no effect on message content, only on whether the message is rendered or not, depending on the version being built. (Note that the majority of 2.1-specific support for the Eleventy build system will be in a separate PR after this gets merged.) |
Replying to @bruce-usab:
I've now added links to end-of-life articles regarding both.
I added a change to reflect that I'm curious as to why this was requested for this specific attribute? |
These will include an obsolescence message, and will not be cross-linked
This reverts commit c7643f8.
Not sure why, but the formatting and related resources differed from what was last seen under WAI/WCAG22 (but matched WAI/WCAG21).
058cfce
to
407efdf
Compare
WAI site pushes and gh-pages deploys no longer depend on the XSLT build process, and #3975 includes code that works _only_ with the Eleventy-based build system. To avoid any accidents, this PR removes the parts of the XSLT process that are no longer needed, i.e. anything exclusively related to generating techniques and understanding pages. (Anything related to JSON generation has been left intact, until such time as that is tackled under the new process as well.) This PR also updates the main README to include a reference to the new build system README, remove references to XML and XSLT, update documentation around term definitions, and add documentation about marking obsolete techniques (added by #3975). Additional README fixes: - Typos - Notation that was being swallowed during markdown parsing (e.g. `<version>`) - Default branch references (updated from master to main)
From backlog call today, I aspire to offer some additional text for the explanations of why obsoleted for the few that (like summary) just have the statement that XYZ is obsolete. |
@bruce-usab If you open that up as a separate PR |
This is a follow-up to #3975 related to @bruce-usab's feedback. Previews: [H35](https://deploy-preview-4027--wcag2.netlify.app/techniques/html/h35), [H45](https://deploy-preview-4027--wcag2.netlify.app/techniques/html/h45), [H46](https://deploy-preview-4027--wcag2.netlify.app/techniques/html/h46), [H70](https://deploy-preview-4027--wcag2.netlify.app/techniques/html/h70), [H73](https://deploy-preview-4027--wcag2.netlify.app/techniques/html/h73)
This PR supersedes #3961; it accomplishes the same output, plus resolves a leftover empty section remaining in that PR.
Related issues: #3651, #3758
Note to WG
I would appreciate eyes on
obsoleteMessage
wording, seen at the end of each technique's About box (or at the top of HTML files in this PR) for restored obsolete techniques:You don't need to worry about the implementation parts of the PR (unless you want to); I expect to ask @iadawn to review that part.
Background
Historically, techniques have been removed from this repository when they become obsolete. However, they are not removed from the WAI site in order to avoid link rot. This is not ideal, as it leaves those pages in isolation with no indication of being obsolete (with the exception of Flash and Silverlight pages, which had a message added by the build process).
Summary
This PR adds support for marking techniques as obsolete via front-matter. When a technique is marked as obsolete, it has the following effects:
This PR also adds considerations for WCAG 2.2's obsolete SC, 4.1.1 Parsing:
Changes
obsoleteSince
- indicates version upon which the technique became obsolete (in XY notation e.g.22
)obsoleteMessage
- Message to display in About this Technique boxobsoleteSince
andobsoleteMessage
setExclusions
There are 2 techniques I have not restored; if folks have suggestions on wording for
obsoleteMessage
for them, I can add them:Note: XSLT build system deprecation
This PR introduces front-matter in some HTML files, which the previous XSLT build system won't know how to handle. Now that we have the Eleventy build system in use for WAI site updates as well as gh-pages deploys, there should be no further dependencies on it, and I plan to remove it and think about updating the main README (update: in #3985).