-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 508: Horizontal review updates to security considerations #510
Conversation
Per Issue #503 this is a draft PR to update the Security Considerations section.
✅ Deploy Preview for wcag2ict ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I offer an iteration (Option 3) on @iadawn suggestion in the Google doc. I drop "however" and start with "as with any additional features".
I am also okay with Option 1 (no change) and Option 2 as proposed. |
Based on Bruce's suggestion, I would remove "new additional"and just use "other" instead. While it sometimes happens that accessibility comes as an afterthought, additional implementation, that's not always the case. This "new additional" would not cover well the use cases where accessibility has indeed been included from the beginning of the project.
|
These two latest proposals got rid of "accessibility" in "accessibility features" - which was a main point in the issue. I'll work on updating the proposal in the Google doc so we can swiftly settle on the right language. See Option 4 there. I can update the PR with the language once we settle on the right way to say it. |
+1 to option 4 in the Google Doc. |
Also +1 to Option 4 in the Google doc. |
+1 to option 4, with edits. I made my edits directly in option 4 in the Google doc, with a suggestion to @maryjom to call this option 5. |
+1 to Option 5 in Google doc, @mitchellevan edits to option 4. Copy/paste:
|
Co-authored-by: Daniel Montalvo <[email protected]>
SHA: 22b9c5b Reason: push, by maryjom Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Per Issue #508 this is a draft PR to update the Security Considerations section. If you have edits to propose, please use the Google doc.