Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Policy integration #151

Closed
ewilligers opened this issue May 1, 2020 · 7 comments · Fixed by #166
Closed

Feature Policy integration #151

ewilligers opened this issue May 1, 2020 · 7 comments · Fixed by #166
Assignees
@ewilligers

Comments

@ewilligers
Copy link
Collaborator

ewilligers commented May 1, 2020 •
edited
Loading

We should consider specifying

The WebShare API is a policy-controlled feature identified by the string "web-share". It's default allowlist is 'self'. When disabled in a document, the share() method MUST return a promise which rejects with a "NotAllowedError" DOMException.

This way, the feature is disallowed by default in cross-origin documents in child browsing contexts.
@marcoscaceres marcoscaceres mentioned this issue May 6, 2020
Merged
@marcoscaceres
Copy link
Member

Sounds great. We can probably integrate the second sentence directly into the .share() method algorithm.

@marcoscaceres
Copy link
Member

Here is how we did it in Payment Request:
https://w3c.github.io/payment-request/#constructor

And:
https://w3c.github.io/payment-request/#feature-policy

@ewilligers
Copy link
Collaborator Author

Chromium implementation task: https://bugs.chromium.org/p/chromium/issues/detail?id=1079104

@marcoscaceres
Copy link
Member

Oh awesome! Will do the same on Gecko side. @ericwilligers, do you want me to draft up a PR?

@ewilligers
Copy link
Collaborator Author

I don't know how to write a WPT for this one.

@marcoscaceres
Copy link
Member

We can copy these: web-platform-tests/wpt#23729

@marcoscaceres
Copy link
Member

With those tests, we can replace all the geo stuff for "share". It should be fairly straight forward.

ewilligers pushed a commit to ewilligers/webappsec-feature-policy that referenced this issue Jul 16, 2020
@ericwilligers
Add entry for web-share feature policy
e9f838f 
Link to
https://www.w3.org/TR/web-share/#feature-policy-integration
which is added in
w3c/web-share#151
ewilligers pushed a commit to ewilligers/web-share that referenced this issue Jul 16, 2020
@ericwilligers
Introduce "web-share" feature policy
79890ab 
resolves w3c#151
@ewilligers ewilligers mentioned this issue Jul 16, 2020
Merged
4 tasks
@ewilligers ewilligers self-assigned this Jul 16, 2020
ewilligers pushed a commit to ewilligers/webappsec-feature-policy that referenced this issue Jul 16, 2020
@ericwilligers
Add entry for web-share feature policy
81a02ef 
Adds link to
https://www.w3.org/TR/web-share/#feature-policy
which is added in
w3c/web-share#151
ewilligers pushed a commit to ewilligers/webappsec-feature-policy that referenced this issue Jul 16, 2020
@ericwilligers
web-share permission policy
2442f55 
"web-share" is being added to the Web Share API spec in
w3c/web-share#151

Blink support is being implemented in
https://chromium-review.googlesource.com/c/chromium/src/+/2299791
@ewilligers ewilligers mentioned this issue Jul 16, 2020
Merged
ewilligers added a commit that referenced this issue Jul 17, 2020
@ewilligers
Introduce "web-share" feature policy (#166)
2ef967a 
resolves #151
ewilligers pushed a commit to ewilligers/webappsec-feature-policy that referenced this issue Jul 17, 2020
@ericwilligers
web-share permission policy
3e1ddf6 
"web-share" was recently added to the Web Share API spec.
w3c/web-share#151

Blink support is being implemented in
https://chromium-review.googlesource.com/c/chromium/src/+/2299791
clelland pushed a commit to w3c/webappsec-permissions-policy that referenced this issue Jul 17, 2020
@ewilligers @ericwilligers
web-share permission policy (#394)
f254030 
"web-share" was recently added to the Web Share API spec.
w3c/web-share#151

Blink support is being implemented in
https://chromium-review.googlesource.com/c/chromium/src/+/2299791

Co-authored-by: Eric Willigers <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ewilligers ewilligers

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduce "web-share" feature policy ewilligers/web-share
2 participants
@marcoscaceres @ewilligers