-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add canShare() method #177
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
0331a1c
Add canShare() method
marcoscaceres a130e8d
add SecureContext and allowed to use check
marcoscaceres f36224b
Add http+https checks to validation
marcoscaceres 0ec77e9
Handle empty files sequence
marcoscaceres 53bf3f0
Update index.html
marcoscaceres fc20b1b
Add purpose for canShare()
marcoscaceres 32bfa3e
Add canShare overload
marcoscaceres fdd10df
Merge branch 'main' into canShare
marcoscaceres f38862e
Merge branch 'main' into canShare
marcoscaceres d4853d8
Merge branch 'main' into canShare
marcoscaceres 6c04cb2
Merge branch 'main' into canShare
marcoscaceres 7828d97
Merge branch 'main' into canShare
marcoscaceres 07322d5
Merge branch 'main' into canShare
marcoscaceres 5dc2244
Merge branch 'main' into canShare
marcoscaceres 7875616
Merge branch 'main' into canShare
marcoscaceres cca9754
Merge branch 'main' into canShare
marcoscaceres cad9d6e
Merge branch 'main' into canShare
marcoscaceres b3ef905
Merge branch 'main' into canShare
marcoscaceres 338d7fa
Specify minimum canShare() to match Chrome/Safari
marcoscaceres File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be marked as historical if we think this is a broken approach?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only if we are not going to ship an alternative - but I don't think anyone plans to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are going to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, yes... there is no plans for any engine to ship anything different. Let's just ship this and be done for now. If we need a new method, we can add it when there is demand for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think Gecko would want to ship anything proven to be broken as a sole solution 🤔
cc @annevk, context: #108 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's ok, but if we can't shift the other implementers then we need to make a process call here (i.e., Mozilla can "formally object" and we figure it out from there).
We have two engines that already ship
.canShare()
already (and have now for over a year).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it depends on real world usage of canShare.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, that too... however, we (you and I) are kinda limited in that we can't actually get that data.
We are at an impasse here :( without input from other implementers willing to change (or even respond to issues), I don't know what we can do 😭
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://chromestatus.com/metrics/feature/timeline/popularity/2737