Small cleanups and feedback from @mounirlamouri #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @mounirlamouri |
padenot
approved these changes
Dec 8, 2020
index.src.html
Outdated
| @@ -73,23 +76,18 @@ | |||
| <dfn>control messages</dfn>. | |||
|
|
|||
| <dfn lt="Enqueues a control message|Queue a control message">Queuing a control | |||
| message</dfn> | |||
| means adding the message to the end of a codec’s <a>control | |||
| message</dfn> means enqueing the message to the codec’s <a>control | |||
There was a problem hiding this comment.
I'm ok with changing the prose here, but then you need to explain what enqueueing and dequeuing mean, or (and I think it would be better) to refer to https://infra.spec.whatwg.org/#queues.
My original prose in the Web Audio API text was written in a way that this was unnecessary, and predates this infra text.
|
Thanks Paul |
|
Hm, IPR is unhappy, but that seems like a bug (I'm still in the w3c incubator group). Filed an issue on them w3c/ash-nazg#188 I'll go ahead with this merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a handful of formatting/style issues and attempts to rely more on concepts from the infra spec.
Still to come, I'm working on PR to refactor the relationship of methods/algorithms for the codec interfaces. What I have currently reduces copy paste, but its a bit hard to read.
Preview | Diff