Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable configuration of AV1 screen content coding tools #662

Merged
merged 3 commits into from
Apr 27, 2023
Merged

Conversation

aboba
Copy link
Collaborator

@aboba aboba commented Apr 11, 2023

Fix for #646
Fix for #478

Rebase of #652

@Djuffin
Copy link
Contributor

Djuffin commented Apr 11, 2023

Is it really a per frame setting?
It seems that #652 does the same but on the VideoEncoderConfig level

@aboba
Copy link
Collaborator Author

aboba commented Apr 12, 2023

During a screen sharing session, the content can change so that screen content coding might no longer be advisable. For example, a slide presentation could include an embedded video, or a user could shift to sharing another tab. libaom supports applying screen content coding on a per-frame basis, so having it applied per-frame in WebCodecs may make sense.

@Djuffin
Copy link
Contributor

Djuffin commented Apr 13, 2023

WebCodecs Editors decision: let's put it into VideoEncoderConfig so VideoEncoder can explicitly refuse it if it's not supported.

@aboba
Copy link
Collaborator Author

aboba commented Apr 15, 2023

PR redone to make it an encoder configuration option, as discussed in the Editor's meeting. This still allows screen content coding to be turned on/off in mid-stream by calling encoder.configure().

@aboba
Copy link
Collaborator Author

aboba commented Apr 25, 2023

Discussed at 14 April 2023 MEDIA WG meeting: https://lists.w3.org/Archives/Public/public-media-wg/2023Apr/0007.html

@aboba
Copy link
Collaborator Author

aboba commented Apr 27, 2023

Editor's meeting: merge it!

@Djuffin Djuffin merged commit 3ec4530 into main Apr 27, 2023
@Djuffin Djuffin deleted the aboba-patch-4 branch April 27, 2023 16:47
github-actions bot added a commit that referenced this pull request Apr 27, 2023
SHA: 3ec4530
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Apr 27, 2023
SHA: 3ec4530
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Apr 27, 2023
SHA: 3ec4530
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Apr 27, 2023
SHA: 3ec4530
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Apr 27, 2023
SHA: 3ec4530
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Apr 27, 2023
SHA: 3ec4530
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Apr 27, 2023
SHA: 3ec4530
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Apr 27, 2023
SHA: 3ec4530
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Apr 27, 2023
SHA: 3ec4530
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Apr 27, 2023
SHA: 3ec4530
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Apr 27, 2023
SHA: 3ec4530
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Apr 27, 2023
SHA: 3ec4530
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Apr 27, 2023
SHA: 3ec4530
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Apr 27, 2023
SHA: 3ec4530
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Apr 27, 2023
SHA: 3ec4530
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Apr 27, 2023
SHA: 3ec4530
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@aboba aboba mentioned this pull request Jun 13, 2023
@fippo
Copy link
Contributor

fippo commented Sep 9, 2023

Late comment but since this hasn't shipped yet... can we stop saying this is "forced" and instead say it gets enabled (i.e. enableScreenContentTools)?
Forcing may have implications e.g. when you try to do "force" it on a hardware encoder where it is not supported. Does that imply it should fail or should this simply not get enabled.

Wordsmithing ;-)

@fippo
Copy link
Contributor

fippo commented Oct 26, 2023

(force... is used by the AV1 spec so keeping this consistent is good)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants