Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clone configuration should perform a deep copy #671

Merged
merged 2 commits into from
May 11, 2023
Merged

Clone configuration should perform a deep copy #671

merged 2 commits into from
May 11, 2023

Conversation

padenot
Copy link
Collaborator

@padenot padenot commented May 10, 2023 •
edited by pr-preview bot
Loading

This fixes #485.

Preview | Diff

@padenot padenot requested review from dalecurtis and aboba May 10, 2023 13:03
dalecurtis
dalecurtis approved these changes May 10, 2023
View reviewed changes
Copy link
Contributor

@dalecurtis dalecurtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Chrome's case we don't intentionally make a deep copy, media code just can't handle Blink GC'd types, so we copy out of the GC type into our own.

index.src.html Outdated Show resolved Hide resolved
@Djuffin Djuffin merged commit 3a96dbd into main May 11, 2023
@Djuffin Djuffin deleted the 485-config-copy branch May 11, 2023 16:05
github-actions bot added a commit that referenced this pull request May 11, 2023
@Djuffin @github-actions
Merge pull request #671 from w3c/485-config-copy
09a7060 
SHA: 3a96dbd
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request May 11, 2023
@Djuffin @github-actions
Merge pull request #671 from w3c/485-config-copy
3ee4f4c 
SHA: 3a96dbd
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request May 11, 2023
@Djuffin @github-actions
Merge pull request #671 from w3c/485-config-copy
06ba0c5 
SHA: 3a96dbd
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request May 11, 2023
@Djuffin @github-actions
Merge pull request #671 from w3c/485-config-copy
ae5125f 
SHA: 3a96dbd
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request May 11, 2023
@Djuffin @github-actions
Merge pull request #671 from w3c/485-config-copy
39041b3 
SHA: 3a96dbd
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request May 11, 2023
@Djuffin @github-actions
Merge pull request #671 from w3c/485-config-copy
99566b3 
SHA: 3a96dbd
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request May 11, 2023
@Djuffin @github-actions
Merge pull request #671 from w3c/485-config-copy
5914e43 
SHA: 3a96dbd
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request May 11, 2023
@Djuffin @github-actions
Merge pull request #671 from w3c/485-config-copy
d9e4ea0 
SHA: 3a96dbd
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request May 11, 2023
@Djuffin @github-actions
Merge pull request #671 from w3c/485-config-copy
d878990 
SHA: 3a96dbd
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request May 11, 2023
@Djuffin @github-actions
Merge pull request #671 from w3c/485-config-copy
bb11bd3 
SHA: 3a96dbd
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request May 11, 2023
@Djuffin @github-actions
Merge pull request #671 from w3c/485-config-copy
78cabd3 
SHA: 3a96dbd
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request May 11, 2023
@Djuffin @github-actions
Merge pull request #671 from w3c/485-config-copy
908dda4 
SHA: 3a96dbd
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request May 11, 2023
@Djuffin @github-actions
Merge pull request #671 from w3c/485-config-copy
8a49c45 
SHA: 3a96dbd
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request May 11, 2023
@Djuffin @github-actions
Merge pull request #671 from w3c/485-config-copy
746ea63 
SHA: 3a96dbd
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request May 11, 2023
@Djuffin @github-actions
Merge pull request #671 from w3c/485-config-copy
949ef34 
SHA: 3a96dbd
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request May 11, 2023
@Djuffin @github-actions
Merge pull request #671 from w3c/485-config-copy
6f8b46a 
SHA: 3a96dbd
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aboba aboba aboba approved these changes

@dalecurtis dalecurtis dalecurtis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarify "Clone Configuration" to eliminate TOCTOU race possibility
4 participants
@padenot @aboba @dalecurtis @Djuffin