Account for any session-independent commands #956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "New Session" command does not specify a session identifier, nor does it depend on the "current session" variable. This is also true of the "Status" command, and any number of extension commands may likewise operate outside the context of any particular session. Skip the substeps related to the current session for any command that does not specify a "session id" variable. Introduce a non-normative note documenting the intention of this condition since it is partially intended to satisfy externally-defined criteria. Furthermore, processing such commands should not involve extracting the "session id" value from the variable named "url variables". Re-locate that step to the branch that concerns only those commands where it is relevant.
jlipps
approved these changes
Jun 21, 2017
|
LGTM. I think this properly captures the intent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "New Session" command does not specify a session identifier, nor
does it depend on the "current session" variable. This is also true of
the "Status" command, and any number of extension commands may likewise
operate outside the context of any particular session.
Skip the substeps related to the current session for any command that
does not specify a "session id" variable. Introduce a non-normative note
documenting the intention of this condition since it is partially
intended to satisfy externally-defined criteria.
Furthermore, processing such commands should not involve extracting the
"session id" value from the variable named "url variables". Re-locate
that step to the branch that concerns only those commands where it is
relevant.
This change is